Skip to content

Conversation

@anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Feb 20, 2025

Description

This PR includes following changes:

  • Fixes work item delete permission bug.
  • Updated work item header breadcrumb.

Type of Change

  • Bug fix

References

[WEB-3436]

Summary by CodeRabbit

  • New Features
    • The project header now displays a translatable label, offering language support based on your locale.
    • The delete issue modal has been enhanced to dynamically update its permission checks using your workspace context, ensuring accurate access controls.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates two components. In the header component, the useTranslation hook is added, replacing a hardcoded label with a translatable string, thus enabling internationalization. In the delete issue modal, the component is wrapped with the observer from mobx-react, and the workspaceSlug is retrieved via the useParams hook. This slug is incorporated into the permissions check alongside projectDetails.id, refining the authorization logic while maintaining the overall control flows.

Changes

File Path Change Summary
web/app/[workspaceSlug]/…/header.tsx Imported useTranslation from @plane/i18n and replaced the hardcoded "Issues" label with t("common.work_items") in the header component.
web/core/…/delete-issue-modal.tsx Wrapped with observer, added useParams to obtain workspaceSlug, and updated the permissions check to include workspaceSlug and projectDetails.id.

Possibly related PRs

  • [WEB-3090]fix: added missing translation #6367: The changes in the main PR, which involve activating the useTranslation hook for a specific component, are related to the retrieved PR that adds missing translations, as both involve modifications to localization functionality.
  • [WEB-3153] improvement: add support for nested translations and ICU formatting #6411: The changes in the main PR, which involve the addition of the useTranslation hook and the activation of the t function for translations, are related to the enhancements made in the retrieved PR that focuses on improving the translation system, including support for nested translations and ICU formatting.
  • chore: platform ux improvement #6555: The changes in the main PR, which involve the addition of the useTranslation hook and the activation of the t function for translating a breadcrumb label, are related to the modifications in the retrieved PR that also focus on translation strings, specifically the simplification of keys in the translations.json files.

Suggested reviewers

  • sriramveeraghanta
  • prateekshourya29

Poem

I hop through lines of code so spry,
Translation magic now makes texts fly.
Breadcrumbs sing in languages new,
Permissions checked with a workspace view.
I, the rabbit, dance with glee,
Celebrating changes that set code free!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a204fe and fc683e2.

📒 Files selected for processing (1)
  • web/app/[workspaceSlug]/(projects)/browse/[workItem]/header.tsx (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sriramveeraghanta sriramveeraghanta merged commit 2d6c26a into preview Feb 20, 2025
3 of 5 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-work-item-delete-permission-and-header-translation branch February 20, 2025 13:02
lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
…6654)

* fix: work item header translation

* fix: work item delete permission
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants