Skip to content

Conversation

@gakshita
Copy link
Collaborator

@gakshita gakshita commented Feb 24, 2025

Description

This PR fixes the auto closing of date range picker on selection of the start date.

References

[WEB-3452]

Summary by CodeRabbit

  • New Features
    • Updated the date range dropdown behavior: after selecting both start and end dates, the dropdown now remains open until manually closed by the user. This change provides more flexibility and control during the date selection process.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 24, 2025

Walkthrough

The change modifies the behavior of the date range dropdown by removing the automatic closing functionality. Specifically, the call to handleClose in the onSelect callback is deleted. This adjustment means that when both from and to dates are selected in the Calendar component, the dropdown will no longer close automatically. There are no changes to exported or public entities.

Changes

File Path Summary
web/core/components/.../date-range.tsx Removed the line (val?.from && val?.to && handleClose();) that conditionally closed the dropdown after a complete date range selection.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Calendar
    participant Dropdown

    User ->> Calendar: Select date range
    Calendar ->> Calendar: Check if both dates are selected

    alt Before change
        Calendar ->> Dropdown: Call handleClose()
        Dropdown -->> User: Dropdown closes automatically
    else After change
        Calendar -->> Dropdown: No call to handleClose()
        Dropdown -->> User: Dropdown remains open
    end
Loading

Possibly related PRs

Suggested labels

🌟enhancement, 🎨UI / UX

Suggested reviewers

  • aaryan610
  • sriramveeraghanta

Poem

I’m a rabbit in the code, hopping with delight,
The dates now play, no auto-close in sight.
A gentle tweak in our dropdown's dance,
Lets users choose with a second glance.
Hop on, code friends, let’s celebrate this night! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bcb9c73 and fd32dc5.

📒 Files selected for processing (1)
  • web/core/components/dropdowns/date-range.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • web/core/components/dropdowns/date-range.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gakshita gakshita changed the title [WEB-3452] Fix date picker auto close [WEB-3452] Fix: date picker auto close Feb 24, 2025
@sriramveeraghanta sriramveeraghanta merged commit e4dd2a6 into preview Feb 24, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-date-picker-auto-close branch February 24, 2025 09:40
aaryan610 pushed a commit that referenced this pull request Apr 9, 2025
* fix: Handled workspace switcher closing on click

* fix: removed auto close for date range picker

Co-authored-by: Akshita Goyal <[email protected]>
lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
* fix: Handled workspace switcher closing on click

* fix: removed auto close for date range picker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants