-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[WEB-3452] Fix: date picker auto close #6662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change modifies the behavior of the date range dropdown by removing the automatic closing functionality. Specifically, the call to Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Calendar
participant Dropdown
User ->> Calendar: Select date range
Calendar ->> Calendar: Check if both dates are selected
alt Before change
Calendar ->> Dropdown: Call handleClose()
Dropdown -->> User: Dropdown closes automatically
else After change
Calendar -->> Dropdown: No call to handleClose()
Dropdown -->> User: Dropdown remains open
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* fix: Handled workspace switcher closing on click * fix: removed auto close for date range picker Co-authored-by: Akshita Goyal <[email protected]>
* fix: Handled workspace switcher closing on click * fix: removed auto close for date range picker
Description
This PR fixes the auto closing of date range picker on selection of the start date.
References
[WEB-3452]
Summary by CodeRabbit