fix: favorite mutation on quick actions

apiserver/plane/app/views/workspace/favorite.py

@@ -34,6 +34,19 @@ def get(self, request, slug):
     def post(self, request, slug):
         try:
             workspace = Workspace.objects.get(slug=slug)
+
+            user_favorites = UserFavorite.objects.filter(
+                workspace=workspace,
+                user_id=request.user.id,
+                entity_type=request.data.get("entity_type"),
+                entity_identifier=request.data.get("entity_identifier")
+            )
+            # If the favorite exists return
+            if request.data.get("entity_identifier") and user_favorites.exists():
+                user_favorite = user_favorites.first()
+                serializer = UserFavoriteSerializer(user_favorite)
+                return Response(serializer.data, status=status.HTTP_200_OK)
+
             serializer = UserFavoriteSerializer(data=request.data)
             if serializer.is_valid():
                 serializer.save(

web/core/store/favorite.store.ts

@@ -111,11 +111,12 @@ export class FavoriteStore implements IFavoriteStore {
    * @returns Promise<IFavorite>
    */
   addFavorite = async (workspaceSlug: string, data: Partial<IFavorite>) => {
-    const id = uuidv4();
     data = { ...data, parent: null, is_folder: data.entity_type === "folder" };
 
+    if (data.entity_identifier && this.entityMap[data.entity_identifier]) return this.entityMap[data.entity_identifier];
     try {
       // optimistic addition
+      const id = uuidv4();
       runInAction(() => {
         set(this.favoriteMap, [id], data);
         data.entity_identifier && set(this.entityMap, [data.entity_identifier], data);
@@ -271,6 +272,7 @@ export class FavoriteStore implements IFavoriteStore {
    * @returns Promise<void>
    */
   deleteFavorite = async (workspaceSlug: string, favoriteId: string) => {
+    if (!this.favoriteMap[favoriteId]) return;
     const parent = this.favoriteMap[favoriteId].parent;
     const children = this.groupedFavorites[favoriteId].children;
     const entity_identifier = this.favoriteMap[favoriteId].entity_identifier;