Skip to content

[WEB-3704] chore: work item store optimization and code refactor #6846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 2 commits into from
Mar 28, 2025
Merged

[WEB-3704] chore: work item store optimization and code refactor #6846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4933f0
chore: work item store optimization and code refactor
anmolsinghbhatia Mar 28, 2025
c49eefa
chore: code refactor
anmolsinghbhatia Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/core/components/issues/sub-issues/issues-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const IssueList: FC<IIssueList> = observer((props) => {
// hooks
const {
subIssues: { subIssuesByIssueId },
} = useIssueDetail();
} = useIssueDetail(issueServiceType);

const subIssueIds = subIssuesByIssueId(parentIssueId);

Expand Down
31 changes: 17 additions & 14 deletions web/core/store/issue/issue-details/issue.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,9 @@ export class IssueStore implements IIssueStore {
const issueIdentifier = `${project_identifier}-${sequence_id}`;
const issueId = issue?.id;
const projectId = issue?.project_id;
const rootWorkItemDetailStore = issue?.is_epic
? this.rootIssueDetailStore.rootIssueStore.epicDetail
: this.rootIssueDetailStore.rootIssueStore.issueDetail;

if (!issue || !projectId || !issueId) throw new Error("Issue not found");

Expand All @@ -315,41 +318,41 @@ export class IssueStore implements IIssueStore {
}

// add identifiers to map
this.rootIssueDetailStore.rootIssueStore.issues.addIssueIdentifier(issueIdentifier, issueId);
rootWorkItemDetailStore.rootIssueStore.issues.addIssueIdentifier(issueIdentifier, issueId);

// add related data
if (issue.issue_reactions) this.rootIssueDetailStore.addReactions(issue.id, issue.issue_reactions);
if (issue.issue_link) this.rootIssueDetailStore.addLinks(issue.id, issue.issue_link);
if (issue.issue_attachments) this.rootIssueDetailStore.addAttachments(issue.id, issue.issue_attachments);
this.rootIssueDetailStore.addSubscription(issue.id, issue.is_subscribed);
if (issue.issue_reactions) rootWorkItemDetailStore.addReactions(issue.id, issue.issue_reactions);
if (issue.issue_link) rootWorkItemDetailStore.addLinks(issue.id, issue.issue_link);
if (issue.issue_attachments) rootWorkItemDetailStore.addAttachments(issue.id, issue.issue_attachments);
rootWorkItemDetailStore.addSubscription(issue.id, issue.is_subscribed);

// fetch related data
// issue reactions
if (issue.issue_reactions) this.rootIssueDetailStore.addReactions(issueId, issue.issue_reactions);
if (issue.issue_reactions) rootWorkItemDetailStore.addReactions(issueId, issue.issue_reactions);

// fetch issue links
if (issue.issue_link) this.rootIssueDetailStore.addLinks(issueId, issue.issue_link);
if (issue.issue_link) rootWorkItemDetailStore.addLinks(issueId, issue.issue_link);

// fetch issue attachments
if (issue.issue_attachments) this.rootIssueDetailStore.addAttachments(issueId, issue.issue_attachments);
if (issue.issue_attachments) rootWorkItemDetailStore.addAttachments(issueId, issue.issue_attachments);

this.rootIssueDetailStore.addSubscription(issueId, issue.is_subscribed);
rootWorkItemDetailStore.addSubscription(issueId, issue.is_subscribed);

// fetch issue activity
this.rootIssueDetailStore.activity.fetchActivities(workspaceSlug, projectId, issueId);
rootWorkItemDetailStore.activity.fetchActivities(workspaceSlug, projectId, issueId);

// fetch issue comments
this.rootIssueDetailStore.comment.fetchComments(workspaceSlug, projectId, issueId);
rootWorkItemDetailStore.comment.fetchComments(workspaceSlug, projectId, issueId);

// fetch sub issues
this.rootIssueDetailStore.subIssues.fetchSubIssues(workspaceSlug, projectId, issueId);
rootWorkItemDetailStore.subIssues.fetchSubIssues(workspaceSlug, projectId, issueId);

// fetch issue relations
this.rootIssueDetailStore.relation.fetchRelations(workspaceSlug, projectId, issueId);
rootWorkItemDetailStore.relation.fetchRelations(workspaceSlug, projectId, issueId);

// fetching states
// TODO: check if this function is required
this.rootIssueDetailStore.rootIssueStore.rootStore.state.fetchProjectStates(workspaceSlug, projectId);
rootWorkItemDetailStore.rootIssueStore.rootStore.state.fetchProjectStates(workspaceSlug, projectId);

return issue;
};
Expand Down