fix: enable email notification by default for new users #7521
Conversation
WalkthroughThe default notification preference settings for new user accounts have been updated. Now, when a new user (who is not a bot) is created, all notification preference flags are set to True instead of False. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/api/plane/db/models/user.py (1)
270-284: Consider a more selective approach to default notifications.The implementation correctly enables all notification types by default for new users. However, enabling every notification type might lead to notification fatigue, especially for new users who are still learning the platform.
Consider enabling only essential notifications by default (e.g.,
mentionandissue_completed) while keeping others as opt-in to improve user experience.If you prefer to keep all notifications enabled, the current implementation is technically sound:
UserNotificationPreference.objects.create( user=instance, + property_change=True, + state_change=True, + comment=True, + mention=True, + issue_completed=True, )Alternative selective approach:
UserNotificationPreference.objects.create( user=instance, - property_change=True, - state_change=True, - comment=True, + property_change=False, + state_change=False, + comment=False, mention=True, issue_completed=True, )
Description
Type of Change
References
#5381
Summary by CodeRabbit