-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[WIKI-569] chore: migrate to tiptap v3 #7526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
1592b59
chore: upgrade to tiptap v3
aaryan610 2dbfb54
chore: update starter kit
aaryan610 c97d40f
chore: tippy to floating-ui migration for mentions
aaryan610 5eac500
fix: merge conflicts resolved from preview
aaryan610 16e489a
chore: update remaining floating menus
aaryan610 cbfc39b
chore: update setEditorValue function
aaryan610 cd48989
fix: potential bugs
aaryan610 b2c23d1
chore: extract out common floating ui positioning logic
aaryan610 a0c14f1
Merge branch 'preview' into chore/tiptap-v3
Palanikannan1437 63d2299
fix: storage api
Palanikannan1437 e3c9b3b
Merge branch 'preview' of https://github.com/makeplane/plane into cho…
aaryan610 5a2184a
fix: bubble menu
aaryan610 5f58830
fix: type errors
aaryan610 e45f958
fix: type errors
aaryan610 d2b939e
fix: merge conflicts resolved from preview
aaryan610 7380696
chore: upgrade tiptap-markdown package
aaryan610 d277a52
fix: mentions close callback
aaryan610 de51429
chore: update bubbling sequence
aaryan610 605ac3c
chore: update package.json
aaryan610 b007c43
chore: update tiptap catalogs
aaryan610 fe93c1d
fix: merge conflicts resolved from preview
aaryan610 2ad7440
fix: add error handling
aaryan610 8d9b772
fix: file plugin types
aaryan610 25de9dc
fix: merge conflicts resolved from preview
aaryan610 73f54d9
chore: update live package.json
aaryan610 42dc2f9
fix: broken lock file
sriramveeraghanta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,22 @@ | ||
| import { ExtensionFileSetStorageKey } from "@/plane-editor/types/storage"; | ||
| // plane imports | ||
| import { ADDITIONAL_EXTENSIONS, CORE_EXTENSIONS } from "@plane/utils"; | ||
| // plane editor imports | ||
| import type { ExtensionFileSetStorageKey } from "@/plane-editor/types/storage"; | ||
|
|
||
| export const NODE_FILE_MAP: { | ||
| [key: string]: { | ||
| fileSetName: ExtensionFileSetStorageKey; | ||
| }; | ||
| } = { | ||
| image: { | ||
| export type NodeFileMapType = Partial< | ||
| Record< | ||
| CORE_EXTENSIONS | ADDITIONAL_EXTENSIONS, | ||
| { | ||
| fileSetName: ExtensionFileSetStorageKey; | ||
| } | ||
| > | ||
| >; | ||
|
|
||
| export const NODE_FILE_MAP: NodeFileMapType = { | ||
| [CORE_EXTENSIONS.IMAGE]: { | ||
| fileSetName: "deletedImageSet", | ||
| }, | ||
| imageComponent: { | ||
| [CORE_EXTENSIONS.CUSTOM_IMAGE]: { | ||
| fileSetName: "deletedImageSet", | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,4 @@ | ||
| import { CharacterCountStorage } from "@tiptap/extension-character-count"; | ||
| // constants | ||
| import type { EmojiStorage } from "@tiptap/extension-emoji"; | ||
| import { CORE_EXTENSIONS } from "@/constants/extension"; | ||
| // extensions | ||
| import type { HeadingExtensionStorage } from "@/extensions"; | ||
| import type { CustomImageExtensionStorage } from "@/extensions/custom-image/types"; | ||
| import type { CustomLinkStorage } from "@/extensions/custom-link"; | ||
| import type { ImageExtensionStorage } from "@/extensions/image"; | ||
| import type { UtilityExtensionStorage } from "@/extensions/utility"; | ||
|
|
||
| export type ExtensionStorageMap = { | ||
| [CORE_EXTENSIONS.CUSTOM_IMAGE]: CustomImageExtensionStorage; | ||
| [CORE_EXTENSIONS.IMAGE]: ImageExtensionStorage; | ||
| [CORE_EXTENSIONS.CUSTOM_LINK]: CustomLinkStorage; | ||
| [CORE_EXTENSIONS.HEADINGS_LIST]: HeadingExtensionStorage; | ||
| [CORE_EXTENSIONS.UTILITY]: UtilityExtensionStorage; | ||
| [CORE_EXTENSIONS.EMOJI]: EmojiStorage; | ||
| [CORE_EXTENSIONS.CHARACTER_COUNT]: CharacterCountStorage; | ||
| }; | ||
|
|
||
| export type ExtensionFileSetStorageKey = Extract<keyof ImageExtensionStorage, "deletedImageSet">; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.