Skip to content

Conversation

@NarayanBavisetti
Copy link
Collaborator

@NarayanBavisetti NarayanBavisetti commented Aug 20, 2025

Description

removed the regex tags calculation in description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • Refactor
    • Streamlined HTML content validation by removing brittle tag-balance checks. Validation now relies on pattern-based safeguards, resulting in more consistent handling of HTML content and fewer unnecessary rejections during submission.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 20, 2025

Walkthrough

Removed the tag-balance validation and its surrounding try/except in validate_html_content. The function now only performs pattern-based checks (malicious HTML patterns and inline event-handler checks). No function signatures or external interfaces changed.

Changes

Cohort / File(s) Summary
HTML validation logic
apps/api/plane/utils/content_validator.py
Deleted basic HTML tag-balance counting and its exception swallowing block; retained and now rely solely on pattern-based malicious HTML and inline event-handler checks. No public APIs altered.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Caller
  participant Validator as ContentValidator.validate_html_content

  Caller->>Validator: validate_html_content(html)
  Note over Validator: Previous flow included<br/>tag-balance counting (removed)
  rect rgba(200,235,255,0.3)
    Validator->>Validator: Check MALICIOUS_HTML_PATTERNS
    alt Pattern matched
      Validator-->>Caller: return False
    else No pattern matched
      Validator->>Validator: Scan for inline event handlers (e.g., on*)
      alt Inline handler found
        Validator-->>Caller: return False
      else None found
        Validator-->>Caller: return True
      end
    end
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A bunny nibbles tags no more,
The balance checks hop out the door.
With whiskers twitching, patterns stay,
To sniff out tricks along the way.
Less tangled thickets, cleaner trail—
Hop, hop—our validator won’t derail! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 409ac30 and aed4304.

📒 Files selected for processing (1)
  • apps/api/plane/utils/content_validator.py (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/api/plane/utils/content_validator.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-regex-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@makeplane
Copy link

makeplane bot commented Aug 20, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes regex-based HTML tag validation logic from the content validator utility as a bug fix. The removed code was performing basic HTML structure validation by counting opening and closing tags to detect malformed HTML.

Key changes:

  • Removed regex-based tag counting validation logic that checked for unmatched HTML tags
  • Simplified the validate_html_content function by eliminating the try-catch block for HTML structure validation
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pushya22 pushya22 merged commit b8a88fe into preview Aug 20, 2025
5 of 9 checks passed
@pushya22 pushya22 deleted the chore-regex-validation branch August 20, 2025 15:56
@NarayanBavisetti NarayanBavisetti mentioned this pull request Aug 25, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants