[WEB-4521] fix: attachments

[sangeethailango]

Description

This PR will fix the issue of missing file extensions on file attachments

Type of Change

• Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

• New Features
  • File downloads now open as attachments with meaningful filenames derived from the asset name, improving saving and sharing across user, project, and workspace asset downloads.
• Bug Fixes
  • Prevents assets from rendering inline in the browser by default, ensuring a consistent download experience.
• Chores
  • Internal adjustments to download handling with no changes to public API signatures.

[coderabbitai]

Walkthrough

Updates presigned URL generation across asset download endpoints to include disposition="attachment" and a filename (derived from asset attributes with UUID fallback). No public API signatures changed; modifications are internal to calls generating presigned URLs for user, project, static, workspace, and project download routes.

Changes

Cohort / File(s)	Summary
Asset download disposition & filename apps/api/plane/app/views/asset/v2.py	Added disposition="attachment" and filename (from asset.attributes.get("name") with UUID fallback in download endpoints) to all generate_presigned_url calls across user, project, static, workspace, and project asset download handlers.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor C as Client
  participant API as API (asset v2)
  participant ST as Storage (S3)

  C->>API: GET /assets/.../download
  API->>API: Lookup asset, derive filename
  API->>ST: generate_presigned_url(object_key, disposition="attachment", filename)
  ST-->>API: Presigned URL
  API-->>C: 302 Redirect / JSON with URL
  Note right of C: Browser downloads file with provided filename

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• [WIKI-520] fix: update content disposition handling in asset download endpoints #7380 — Also adjusts asset download endpoints to separate disposition and filename with UUID fallback.
• [WEB-4316] chore: new endpoints to download an asset #7207 — Adds content-disposition="attachment" and filename to S3 presign in the same asset views.

Suggested labels

⚙️backend

Suggested reviewers

• pablohashescobar
• dheeru0198

Poem

A bunny signs URLs with cheer,
"Attach!" says I, "and name it here."
No files slip by with nameless grace,
Each download hops to its right place.
With tidy tags and carrots bright,
Our assets land just right tonight. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-attachment-download

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WEB-4521] File Attachment Downloads Without Extension

Comment Automatically Generated by Plane

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

apps/api/plane/app/views/asset/v2.py (1)

444-448: Verify no inline asset rendering is broken by forcing attachment
Automated search found no frontend calls to these /api/.../assets endpoints; manually confirm they aren’t used for inline images (avatars, covers, logos). If they are, make disposition conditional on asset.entity_type.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ddeabee and 37d83f8.

📒 Files selected for processing (1)

• apps/api/plane/app/views/asset/v2.py (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

apps/api/plane/app/views/asset/v2.py (1)

apps/api/plane/settings/storage.py (1)

• generate_presigned_url (114-140)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (javascript)