Skip to content

[WIKI-556] fix : invert tracking logic #7668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 1 commit into from
Aug 28, 2025
Merged

[WIKI-556] fix : invert tracking logic #7668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api/plane/app/views/page/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def partial_update(self, request, slug, project_id, pk):
def retrieve(self, request, slug, project_id, pk=None):
page = self.get_queryset().filter(pk=pk).first()
project = Project.objects.get(pk=project_id)
track_visit = request.query_params.get("track_visit", "false").lower() == "true"
track_visit = request.query_params.get("track_visit", "true").lower() == "true"

"""
if the role is guest and guest_view_all_features is false and owned by is not
Expand Down
5 changes: 1 addition & 4 deletions ...[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/[pageId]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,7 @@ const PageDetailsPage = observer(() => {
const { error: pageDetailsError } = useSWR(
workspaceSlug && projectId && pageId ? `PAGE_DETAILS_${pageId}` : null,
workspaceSlug && projectId && pageId
? () =>
fetchPageDetails(workspaceSlug?.toString(), projectId?.toString(), pageId.toString(), {
trackVisit: true,
})
? () => fetchPageDetails(workspaceSlug?.toString(), projectId?.toString(), pageId.toString())
: null,
{
revalidateIfStale: true,
Expand Down
13 changes: 5 additions & 8 deletions apps/web/core/store/pages/project-page.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export interface IProjectPageStore {
workspaceSlug: string,
projectId: string,
pageId: string,
{ trackVisit }: { trackVisit: boolean }
options?: { trackVisit?: boolean }
) => Promise<TPage | undefined>;
createPage: (pageData: Partial<TPage>) => Promise<TPage | undefined>;
removePage: (pageId: string) => Promise<void>;
Expand Down Expand Up @@ -244,12 +244,9 @@ export class ProjectPageStore implements IProjectPageStore {
* @description fetch the details of a page
* @param {string} pageId
*/
fetchPageDetails = async (
workspaceSlug: string,
projectId: string,
pageId: string,
{ trackVisit }: { trackVisit: boolean }
) => {
fetchPageDetails = async (...args: Parameters<IProjectPageStore["fetchPageDetails"]>) => {
const [workspaceSlug, projectId, pageId, options] = args;
const { trackVisit } = options || {};
try {
if (!workspaceSlug || !projectId || !pageId) return undefined;

Expand All @@ -259,7 +256,7 @@ export class ProjectPageStore implements IProjectPageStore {
this.error = undefined;
});

const page = await this.service.fetchById(workspaceSlug, projectId, pageId, trackVisit);
const page = await this.service.fetchById(workspaceSlug, projectId, pageId, trackVisit ?? true);

runInAction(() => {
if (page?.id) {
Expand Down
Loading