[WEB-4838] fix: github logo theme

[anmolsinghbhatia]

Description

This PR updates the GitHub logo to correctly support theme variations.

Type of Change

• Bug fix

Media

Before	After

Summary by CodeRabbit

• Bug Fixes
  • Fixed GitHub sign-in button icon to correctly match the active theme. Dark theme now displays the light GitHub logo, and light theme displays the dark logo, improving contrast and readability. This resolves the previous theme inversion and ensures consistent branding across authentication screens in both Space and Web apps. No changes to sign-in behavior—only the icon appearance was updated.

[coderabbitai]

Walkthrough

In two auth-root components, the GitHub OAuth icon mapping was inverted to match theme: dark theme now uses the light GitHub logo and light theme uses the dark GitHub logo. No other logic, signatures, or control flow were changed.

Changes

Cohort / File(s)	Change Summary
Auth OAuth icon mapping apps/space/core/components/account/auth-forms/auth-root.tsx, apps/web/core/components/account/auth-forms/auth-root.tsx	Swapped GitHub OAuth icon selection: dark theme → GithubLightLogo, light theme → GithubDarkLogo. No other fields or exports modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• [WEB-4542] feat: god mode auth revamp and code refactor #7563 — Also flips theme-based logo/spinner selections, similar icon inversion pattern.

Suggested labels

🐛bug

Suggested reviewers

• sriramveeraghanta
• vamsikrishnamathala

Poem

A hop, a flip—icons switch by night and day,
Dark gets light, and light turns dark—hooray!
I twitch my whiskers, theme-aware delight,
Buttons now gleam perfectly right.
Thump-thump! says the rabbit, merge away. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4b74751 and d501e2a.

📒 Files selected for processing (2)

• apps/space/core/components/account/auth-forms/auth-root.tsx (1 hunks)
• apps/web/core/components/account/auth-forms/auth-root.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Build and lint web apps

🔇 Additional comments (1)

apps/web/core/components/account/auth-forms/auth-root.tsx (1)

124-130: LGTM: correct GitHub icon mapping by theme

Dark theme uses GithubDarkLogo, light theme uses GithubLightLogo. This aligns with expected contrast and should fix the visual bug.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-github-logo-theme

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WEB-4838] Fix GitHub Logo for Dark Mode

Comment Automatically Generated by Plane

[Copilot]

Pull Request Overview

This PR fixes the GitHub logo theme support by correcting the conditional logic that determines which logo variant to display based on the current theme.

• Swaps the GitHub logo variants in the theme conditional to properly display the light logo on dark themes and dark logo on light themes

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
apps/web/core/components/account/auth-forms/auth-root.tsx	Updates GitHub logo theme logic to show GithubDarkLogo for dark theme
apps/space/core/components/account/auth-forms/auth-root.tsx	Updates GitHub logo theme logic to show GithubLightLogo for dark theme

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}