Skip to content

Conversation

@pablohashescobar
Copy link
Member

@pablohashescobar pablohashescobar commented Sep 3, 2025

Description

fix: remove caching decorator from workspace states endpoint

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Test Scenarios

  • Delete the state and it should appear deleted on refresh

References

WEB-4795

Summary by CodeRabbit

  • Bug Fixes
    • Workspace state listings now update immediately, preventing stale results that could appear due to previously cached responses. Users should see the most current state information without delay after changes are made.

Copilot AI review requested due to automatic review settings September 3, 2025 11:41
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 3, 2025

Walkthrough

Removed response caching from WorkspaceStatesEndpoint.get by deleting the cache_response import and decorator. The endpoint’s logic and signature remain unchanged.

Changes

Cohort / File(s) Summary of changes
API workspace states caching removal
apps/api/plane/app/views/workspace/state.py
Deleted cache_response import and decorator from WorkspaceStatesEndpoint.get; retained existing query, serialization, and response logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

ready to merge

Suggested reviewers

  • dheeru0198

Poem

Hop hop! No cache to stash,
Fresh states in a single dash.
Headers light, the path made clear,
Straight from burrow to your ear.
Carrot-coded, crisp and plain—
Requests now breeze across the plain. 🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 59ace4f and d177b61.

📒 Files selected for processing (1)
  • apps/api/plane/app/views/workspace/state.py (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/api/plane/app/views/workspace/state.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-workspace-states

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes caching decorator from the WorkspaceStatesEndpoint to fix an issue where deleted states were not appearing as deleted upon page refresh due to stale cache data.

  • Removed cache_response import from workspace state view
  • Removed @cache_response(60 * 60 * 2) decorator from the get method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@makeplane
Copy link

makeplane bot commented Sep 3, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@sriramveeraghanta sriramveeraghanta merged commit 49a4003 into preview Sep 3, 2025
7 of 10 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-workspace-states branch September 3, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants