[WEB-5170] feat: navigation revamp #8162
+3,781
−758
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,61 +1,43 @@ | ||
| import { observer } from "mobx-react"; | ||
| import { useParams } from "next/navigation"; | ||
| // hooks | ||
| import { Header, Row } from "@plane/ui"; | ||
| import { AppHeader } from "@/components/core/app-header"; | ||
| import { TabNavigationRoot } from "@/components/navigation"; | ||
| import { useIssueDetail } from "@/hooks/store/use-issue-detail"; | ||
| // local components | ||
| import { WorkItemDetailsHeader } from "./work-item-header"; | ||
|
|
||
| export const ProjectWorkItemDetailsHeader = observer(function ProjectWorkItemDetailsHeader() { | ||
| // router | ||
| const { workspaceSlug, workItem } = useParams(); | ||
| // store hooks | ||
| const { | ||
| issue: { getIssueById, getIssueIdByIdentifier }, | ||
| } = useIssueDetail(); | ||
| // derived values | ||
| const issueId = getIssueIdByIdentifier(workItem?.toString()); | ||
| const issueDetails = issueId ? getIssueById(issueId?.toString()) : undefined; | ||
|
|
||
| return ( | ||
| <> | ||
| <div className="z-20"> | ||
| <Row className="h-header flex gap-2 w-full items-center border-b border-custom-border-200 bg-custom-sidebar-background-100"> | ||
| <div className="flex items-center gap-2 divide-x divide-custom-border-100 h-full w-full"> | ||
| <div className="flex items-center h-full w-full flex-1"> | ||
| <Header className="h-full"> | ||
| <Header.LeftItem className="h-full max-w-full"> | ||
| <TabNavigationRoot | ||
| workspaceSlug={workspaceSlug} | ||
| projectId={issueDetails?.project_id?.toString() ?? ""} | ||
| /> | ||
| </Header.LeftItem> | ||
| </Header> | ||
| </div> | ||
| </div> | ||
| </Row> | ||
| </div> | ||
| <AppHeader header={<WorkItemDetailsHeader />} /> | ||
| </> | ||
| ); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| "use client"; | ||
|
|
||
| import React from "react"; | ||
| import { observer } from "mobx-react"; | ||
| import { useParams } from "next/navigation"; | ||
| // plane ui | ||
| import { WorkItemsIcon } from "@plane/propel/icons"; | ||
| import { Breadcrumbs, Header } from "@plane/ui"; | ||
| // components | ||
| import { BreadcrumbLink } from "@/components/common/breadcrumb-link"; | ||
| import { IssueDetailQuickActions } from "@/components/issues/issue-detail/issue-detail-quick-actions"; | ||
| // hooks | ||
| import { useIssueDetail } from "@/hooks/store/use-issue-detail"; | ||
| import { useProject } from "@/hooks/store/use-project"; | ||
| import { useAppRouter } from "@/hooks/use-app-router"; | ||
|
|
||
| export const WorkItemDetailsHeader = observer(() => { | ||
| // router | ||
| const router = useAppRouter(); | ||
| const { workspaceSlug, workItem } = useParams(); | ||
| // store hooks | ||
| const { getProjectById, loader } = useProject(); | ||
| const { | ||
| issue: { getIssueById, getIssueIdByIdentifier }, | ||
| } = useIssueDetail(); | ||
| // derived values | ||
| const issueId = getIssueIdByIdentifier(workItem?.toString()); | ||
| const issueDetails = issueId ? getIssueById(issueId.toString()) : undefined; | ||
| const projectId = issueDetails ? issueDetails?.project_id : undefined; | ||
| const projectDetails = projectId ? getProjectById(projectId?.toString()) : undefined; | ||
|
|
||
| if (!workspaceSlug || !projectId || !issueId) return null; | ||
| return ( | ||
| <Header> | ||
| <Header.LeftItem> | ||
| <Breadcrumbs onBack={router.back} isLoading={loader === "init-loader"}> | ||
| <Breadcrumbs.Item | ||
| component={ | ||
| <BreadcrumbLink | ||
| label="Work Items" | ||
| href={`/${workspaceSlug}/projects/${projectId}/issues/`} | ||
| icon={<WorkItemsIcon className="h-4 w-4 text-custom-text-300" />} | ||
| /> | ||
| } | ||
| /> | ||
| <Breadcrumbs.Item | ||
| component={ | ||
| <BreadcrumbLink | ||
| label={projectDetails && issueDetails ? `${projectDetails.identifier}-${issueDetails.sequence_id}` : ""} | ||
| /> | ||
| } | ||
| /> | ||
| </Breadcrumbs> | ||
| </Header.LeftItem> | ||
| <Header.RightItem> | ||
| {projectId && issueId && ( | ||
| <IssueDetailQuickActions | ||
| workspaceSlug={workspaceSlug?.toString()} | ||
| projectId={projectId?.toString()} | ||
| issueId={issueId?.toString()} | ||
| /> | ||
| )} | ||
| </Header.RightItem> | ||
| </Header> | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Empty projectId passed to TabNavigationRoot component
When
issueDetails?.project_idis undefined, an empty string is passed toTabNavigationRootas theprojectIdprop. This causes the component to execute hooks likeuseTabPreferences,useNavigationItems, anduseProjectActionswith an invalid empty projectId before the null check at line 143 returns early. These hooks may attempt API calls or state operations with the empty string, potentially causing errors or unnecessary network requests. The component should return early or handle the undefined case before renderingTabNavigationRoot.