[WEB-5508] fix: improve error handling in AuthFormRoot by ensuring safe access to error_code

[prateekshourya29]

Description

Type of Change

• Bug fix (non-breaking change which fixes an issue)

References

Fixes: PLANE-WEB-3S9

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling robustness in authentication form processing to prevent potential failures in edge cases.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[makeplane]

Linked to Plane Work Item(s)

• [WEB-5508] [plane-web] TypeError: Cannot read properties of undefined (reading 'toString')

This comment was auto-generated by Plane

[coderabbitai]

Walkthrough

The change adds optional chaining to a .toString() method call in an error handler within the generateEmailUniqueCode function, protecting against undefined error_code values before invoking the method.

Changes

Cohort / File(s)	Summary
Error handling defensive coding apps/web/core/components/account/auth-forms/form-root.tsx	Modified catch block to use optional chaining on toString() call: changed error?.error_code.toString() to error?.error_code?.toString()

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single-line defensive programming change in error handling path
• No logic alterations or control flow modifications
• Optional chaining prevents potential null reference errors

Poem

A rabbit hops through error trees,
With chaining guards and tested breeze,
No null shall slip, no crash shall creep,
Safe bounds for data, safe and deep! 🐰✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete; critical sections like detailed description, screenshots/media, and test scenarios are missing or only contain template placeholders.	Complete the description section with details about the fix, add any relevant screenshots/media, and document the test scenarios performed to verify the changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: improving error handling in AuthFormRoot by ensuring safe access to error_code.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-auth-error-handling

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d38147b and c12bca2.

📒 Files selected for processing (1)

• apps/web/core/components/account/auth-forms/form-root.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,mts,cts}

📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)

**/*.{ts,tsx,mts,cts}: Use const type parameters for more precise literal inference in TypeScript 5.0+
Use the satisfies operator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicit is return types in filter/check functions
Use NoInfer<T> utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing in switch(true) blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacy experimentalDecorators
Use using declarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Use with { type: "json" } for import attributes; avoid deprecated assert syntax (TypeScript 5.3/5.8+)
Use import type explicitly when importing types to ensure they are erased during compilation, respecting verbatimModuleSyntax flag
Use .ts, .mts, .cts extensions in import type statements (TypeScript 5.2+)
Use import type { Type } from "mod" with { "resolution-mode": "import" } for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize new Set methods like union, intersection, etc., when available (TypeScript 5.5+)
Use Object.groupBy / Map.groupBy standard methods for grouping instead of external libraries (TypeScript 5.4+)
Use Promise.withResolvers() for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted, toSpliced, with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields via super in classes (TypeScript 5....

Files:

• apps/web/core/components/account/auth-forms/form-root.tsx

🧠 Learnings (1)

📚 Learning: 2025-07-08T13:41:19.928Z

Learnt from: prateekshourya29
Repo: makeplane/plane PR: 7363
File: apps/web/helpers/react-hook-form.helper.ts:9-19
Timestamp: 2025-07-08T13:41:19.928Z
Learning: In the apps/web/helpers/react-hook-form.helper.ts file, the getNestedError function's FieldError detection logic using "message" property check is sufficient for their use case, and more robust type checking is not required.

Applied to files:

• apps/web/core/components/account/auth-forms/form-root.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Build and lint web apps
• GitHub Check: Analyze (javascript)

🔇 Additional comments (1)

apps/web/core/components/account/auth-forms/form-root.tsx (1)

94-97: Optional chaining on error_code correctly hardens error handling

Updating to error?.error_code?.toString() avoids a TypeError when error exists but error.error_code is null/undefined, and it matches the pattern already used in the email verification catch block. This cleanly addresses the Sentry crash without changing downstream behavior.

If possible, re-run the PLANE-WEB-3S9 reproduction path or check Sentry after deployment to confirm the specific error event no longer occurs.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}