[WEB-5510] fix: handle null values in context indicator for improved stability

[prateekshourya29]

Description

Type of Change

• Bug fix (non-breaking change which fixes an issue)

References

Fixes: PLANE-WEB-3T4

Summary by CodeRabbit

Release Notes

• Chores
  • Internal code reorganization and structural improvements for enhanced maintainability.
  • Improved safety checks in context indicator handling to prevent potential edge-case issues.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[makeplane]

Linked to Plane Work Item(s)

• [WEB-5510] [plane-web] TypeError: can't access property "toString", n is undefined

This comment was auto-generated by Plane

[coderabbitai]

Walkthrough

Two hook files updated: import path changed to absolute alias with type reference normalized; type casting removed from activeContext prop and null-check added for workItemIdentifier safety.

Changes

Cohort / File(s)	Summary
Type import consolidation apps/web/ce/components/command-palette/power-k/hooks/use-extended-context-indicator.ts	Import path updated from relative ../types to absolute alias @/components/power-k/core/types; type reference TPowerKContextTypeExtended renamed to TPowerKContextType throughout TArgs definition.
Type casting removal & null-safety apps/web/core/components/power-k/hooks/use-context-indicator.ts	Type-casted activeContext prop replaced with plain activeContext; null-check safeguard added for workItemIdentifier to prevent undefined toString() calls.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Import path consolidation is straightforward; verify absolute alias resolves correctly
• Type reference rename is propagated consistently; confirm no orphaned references remain
• Null-check logic is defensive; validate it aligns with workItemIdentifier usage expectations

Poem

🐰 Types consolidated, imports aligned so neat,
A null-check safeguard makes the flow complete,
No casting shadows in the light of day,
Just cleaner paths in every way! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete. While it correctly marks the type of change as 'Bug fix', it lacks crucial sections: no detailed description of the changes, missing screenshots/media section, no test scenarios documented, and the reference link appears incomplete.	Expand the description with details of changes made, add test scenarios demonstrating the null-handling fixes, and ensure the References section contains a properly formatted issue link.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: handling null values in context indicator for stability. It's specific, concise, and directly reflects the changes made.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-WEB-5510

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eddf80a and d4444ab.

📒 Files selected for processing (2)

• apps/web/ce/components/command-palette/power-k/hooks/use-extended-context-indicator.ts (1 hunks)
• apps/web/core/components/power-k/hooks/use-context-indicator.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,mts,cts}

📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)

**/*.{ts,tsx,mts,cts}: Use const type parameters for more precise literal inference in TypeScript 5.0+
Use the satisfies operator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicit is return types in filter/check functions
Use NoInfer<T> utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing in switch(true) blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacy experimentalDecorators
Use using declarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Use with { type: "json" } for import attributes; avoid deprecated assert syntax (TypeScript 5.3/5.8+)
Use import type explicitly when importing types to ensure they are erased during compilation, respecting verbatimModuleSyntax flag
Use .ts, .mts, .cts extensions in import type statements (TypeScript 5.2+)
Use import type { Type } from "mod" with { "resolution-mode": "import" } for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize new Set methods like union, intersection, etc., when available (TypeScript 5.5+)
Use Object.groupBy / Map.groupBy standard methods for grouping instead of external libraries (TypeScript 5.4+)
Use Promise.withResolvers() for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted, toSpliced, with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields via super in classes (TypeScript 5....

Files:

• apps/web/core/components/power-k/hooks/use-context-indicator.ts
• apps/web/ce/components/command-palette/power-k/hooks/use-extended-context-indicator.ts

🧠 Learnings (4)

📚 Learning: 2025-11-25T10:18:05.172Z

Learnt from: CR
Repo: makeplane/plane PR: 0
File: .github/instructions/typescript.instructions.md:0-0
Timestamp: 2025-11-25T10:18:05.172Z
Learning: Applies to **/*.{ts,tsx,mts,cts} : Use `import type { Type } from "mod" with { "resolution-mode": "import" }` for specific module resolution contexts (TypeScript 5.3+)

Applied to files:

• apps/web/core/components/power-k/hooks/use-context-indicator.ts

📚 Learning: 2025-10-01T15:30:17.605Z

Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7888
File: packages/propel/src/avatar/avatar.stories.tsx:2-3
Timestamp: 2025-10-01T15:30:17.605Z
Learning: In the makeplane/plane repository, avoid suggesting inline type imports (e.g., `import { Avatar, type TAvatarSize }`) due to bundler compatibility issues. Keep type imports and value imports as separate statements.

Applied to files:

• apps/web/core/components/power-k/hooks/use-context-indicator.ts

📚 Learning: 2025-10-09T20:42:31.843Z

Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7922
File: apps/admin/app/(all)/(dashboard)/ai/form.tsx:19-19
Timestamp: 2025-10-09T20:42:31.843Z
Learning: In the makeplane/plane repository, React types are globally available through TypeScript configuration. Type annotations like React.FC, React.ReactNode, etc. can be used without explicitly importing the React namespace. The codebase uses the modern JSX transform, so React imports are not required for JSX or type references.

Applied to files:

• apps/web/core/components/power-k/hooks/use-context-indicator.ts

📚 Learning: 2025-10-21T17:22:05.204Z

Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7989
File: apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/pages/(detail)/[pageId]/page.tsx:45-46
Timestamp: 2025-10-21T17:22:05.204Z
Learning: In the makeplane/plane repository, the refactor from useParams() to params prop is specifically scoped to page.tsx and layout.tsx files in apps/web/app (Next.js App Router pattern). Other components (hooks, regular client components, utilities) should continue using the useParams() hook as that is the correct pattern for non-route components.

Applied to files:

• apps/web/core/components/power-k/hooks/use-context-indicator.ts

🧬 Code graph analysis (1)

apps/web/ce/components/command-palette/power-k/hooks/use-extended-context-indicator.ts (1)

apps/web/core/components/power-k/core/types.ts (1)

• TPowerKContextType (9-9)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Build and lint web apps

🔇 Additional comments (3)

apps/web/ce/components/command-palette/power-k/hooks/use-extended-context-indicator.ts (1)

2-5: LGTM! Type generalization and import path improvements.

The changes correctly generalize the type from TPowerKContextTypeExtended to TPowerKContextType. Since TPowerKContextType is a union that includes TPowerKContextTypeExtended, this makes the hook more flexible while maintaining type safety. The absolute import path @/components/power-k/core/types is also cleaner and more maintainable than the relative path.

apps/web/core/components/power-k/hooks/use-context-indicator.ts (2)

27-27: LGTM! Safer type handling without cast.

Removing the type cast when passing activeContext to useExtendedContextIndicator is safer. Type casts can hide potential type mismatches, and since TPowerKContextType already includes the extended types as a union, the cast was unnecessary.

---

33-33: LGTM! Critical null safety fix.

The null check for workItemIdentifier correctly prevents a TypeError when the route parameter is undefined. This aligns with the PR's objective to handle null values and resolves the Sentry issue. The pattern is now consistent with other context types (cycle, module, page) which already have similar null checks on lines 37, 42, and 47.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}