Jennie RPS Challenge solution so far#2131
Open
Jenniered wants to merge 11 commits intomakersacademy:mainfrom
Open
Jennie RPS Challenge solution so far#2131Jenniered wants to merge 11 commits intomakersacademy:mainfrom
Jenniered wants to merge 11 commits intomakersacademy:mainfrom
Conversation
Hafizalimi7
reviewed
Jun 6, 2022
Hafizalimi7
left a comment
Hafizalimi7
left a comment
There was a problem hiding this comment.
so far so good, keep up the good work
|
|
||
| run! if app_file == $0 | ||
| end | ||
|
|
There was a problem hiding this comment.
App file is nice and understandable !
| <h1 style="font-family: Tahoma" > | ||
| Let's play Joe | ||
| </h1> | ||
|
|
| @@ -0,0 +1,10 @@ | |||
| class ComputerChoice | |||
| def initialize | |||
| @choices = ["Rock", "Paper", "Scissors"] | |||
There was a problem hiding this comment.
put @choice object out of initialiser method
| def game_result | ||
| if @player_choice == "Rock" && @computer_choice == "Scissors" | ||
| return "Win" | ||
| elsif @player_choice == "Rock" && @computer_choice == "Paper" |
| return "Win" | ||
| elsif @player_choice == "Scissors" && @computer_choice == "Rock" | ||
| return "Lose" | ||
| else |
There was a problem hiding this comment.
possibly could do one line if statements , i.e
if @player_choice == "Rock" && @computer_choice == "Scissors" || @player_choice == "Paper" && @computer_choice == "Rock"
return "Win"
| end | ||
|
|
||
|
|
||
|
|
"updating README from remote"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.