rps challenge - raphaella#2137
Open
raphaella-rose wants to merge 3 commits intomakersacademy:mainfrom
Open
Conversation
BenjaminNeustadt
left a comment
BenjaminNeustadt
left a comment
There was a problem hiding this comment.
The tests are good, I personally like to write the controller first as it feels easier that way to know whether the get requests and post requests are working correctly. Very nice work
| feature 'single player game' do | ||
| xscenario 'player selects rock' do | ||
| visit('/') | ||
| fill_in :player_name, with: 'Raphaella' |
There was a problem hiding this comment.
this test is comprehensive, and understandable. I just wonder whether you could use the web_helper 'sign in and play' here instead of fill_in[...]?
| <div>Player: <%= @player_name %></div> | ||
| <div>Player: <%= @player.name %></div> | ||
| <form action='/weapon_selection' method='post'> | ||
| <input type='submit' value='Rock' name='weapon'> |
There was a problem hiding this comment.
this is really nice, I am going to try implement something in my own code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.