Gawain Hewitt Takeaway challenge by gawainhewitt · Pull Request #2235 · makersacademy/takeaway-challenge

gawainhewitt · 2022-05-03T08:18:18Z

Gawain Hewitt

Please write your full name here to make it easier to find your pull request.

User stories

Please list which user stories you've implemented (delete the ones that don't apply).

User story 1: "I would like to see a list of dishes with prices"
User story 2: "I would like to be able to select some number of several available dishes"
User story 3: "I would like to check that the total I have been given matches the sum of the various dishes in my order"

README checklist

My readme is very basic to be honest

archiemartini

Really like this, will look very nice in action

archiemartini · 2022-05-03T09:12:50Z

lib/takeaway.rb

+class Takeaway
+  attr_reader :menu
+  def initialize
+    @menu = Menu.new


I'm impressed you definitely know what you're doing, especially with the corresponding tests

I'm no expert in dependency injection, but this article near the beginning

https://medium.com/@Bakku1505/introduction-to-dependency-injection-in-ruby-dc238655a278

explains how linking the classes together so "strongly" ie 'def initialize... @menu = Menu.new' can cause issues down the line

archiemartini · 2022-05-03T09:13:57Z

spec/menu_spec.rb

+      subject.show
+    end.to output("1. Chips - £1\n2. Tofu - £2\n3. Broccoli - £1\n4. Ice_cream - £2\n").to_stdout
+  end
+


your general ruby syntax and string-morphing is fantastic!

archiemartini · 2022-05-03T09:15:19Z

spec/takeaway_spec.rb

+    expect(subject.menu).to receive(:show)
+    subject.show_menu
+  end
+


again, already thinking about testing injection (looking at commit 1) here is very switched on. nice. took a lot of research/cheating for me to come to tests like this

archiemartini · 2022-05-03T09:18:36Z

spec/takeaway_spec.rb

@@ -1,15 +1,31 @@
 require 'takeaway'
+require 'stringio'


You'll have to clue me in on this

archiemartini · 2022-05-03T09:26:02Z

lib/takeaway.rb

+    order_item[:quantity] = quantity
+    @summary << order_item
+  end
+


Really impressive thought about actual user interface, certainly going beyond what is required. You have my sympathy and respect for keeping your head around it though

archiemartini · 2022-05-03T09:27:55Z

lib/menu.rb

    @dishes.each do |dish|
-      "food #{dish[:food]}"
-      if _dish == dish[:food]
+      if the_dish == dish[:food]


I feel this could be simplified to a ternary operator

ie 'the_dish == dish[:food] ? true : false

Maybe this method could also be renamed to something like contains_dish? so it's more explicit on what it does

leoht

Well done, that's great work - I left some comments about a few different things to improve, but let me know if you'd like to discuss this feedback more in depth :)

leoht · 2022-05-06T10:14:21Z

lib/takeaway.rb

+  end
+
+  def order
+    loop do


Nice that you've worked with user input as well! I'd suggest looking at extracting further this logic into a new class, maybe named Cli or Interface, which would contain methods such as clarify_order or ask_for_order. It could probably also handle the display of the menu (which is right now in the Menu class). This way you can make the main Takeaway and Menu classes do a bit less, and it also makes it easier to test the input/output, as there will be only one class that directly uses puts or gets, so you remove the need to mock these for the other classes

leoht · 2022-05-06T10:18:04Z

spec/menu_spec.rb

+
+  context '#show' do
+    it 'should display menu' do
+      # output = <<~MENU 


I reckon this didn't work because the heredoc syntax needs the "ending" tag (in your case MENU) to be on its own line, at the very beginning of the line (without any blank space before). This would make it:

it 'should display menu' do output = <<~MENU 1. Chips - £1 2. Tofu - £2 3. Broccoli - £1 4. Ice_cream - £2 MENU # ... end

leoht · 2022-05-06T10:22:27Z

lib/takeaway.rb

+  end
+
+  def confirm_order
+    @summary.each do |dish|


This could also be part of the new class mentioned above - usually it's good practice to split the code that deals with "presenting" or display, from the code that is dealing with pure data or logic. This way, it's easier to change things related to how looks the program outputs (think formatting, translating, or more complex things!) without touching at the core logic of the program, which stays the same no matter how the output is presented and how the input is provided

leoht · 2022-05-06T10:23:18Z

spec/feature_test_spec.rb

+  end
+
+  def place_order_with_input(*order)
+    input = StringIO.new(order.join("\n") + "\n" + "\n" + "\n")


Really nice way to mock IO!

leoht · 2022-05-06T10:25:49Z

lib/menu.rb

    @dishes.each do |dish|
-      "food #{dish[:food]}"
-      if _dish == dish[:food]
+      if the_dish == dish[:food]


Maybe this method could also be renamed to something like contains_dish? so it's more explicit on what it does

leoht · 2022-05-06T10:26:49Z

lib/menu.rb

+    @input = input
+    @output = output
+    @dishes = [{ food: :Chips, price: 1 }, 
+      { food: :Tofu, price: 2 }, { food: :Broccoli, price: 1 }, 


Minor one here - it's probably better to leave the dish names as strings rather than symbols, as symbols are mostly used for keys, special configuration values, enumerated values, etc, rather than purely "textual" values

leoht · 2022-05-06T10:27:57Z

spec/feature_test_spec.rb

+describe 'Featuretest' do
+  context '#order' do
+    it 'will ask again if item mispelt' do
+      output = place_order_with_input("Brocoli", "Broccoli")


Nice one! This test suite should probably contain a bit more tests, at least one testing the whole integration of the different components with a successful order process, and assert the output of the takeaway.order method

gawainhewitt added 6 commits April 30, 2022 08:51

step 1 working

0909b51

writing tests for user input

8883752

working tests to check dishes against menu

9c5f633

tdd 1 order and mispelt, stuck on many orders

ca00cf9

order can be made, user story 2 complete

00e89d8

Completed user story 3

124e7f0

archiemartini reviewed May 3, 2022

View reviewed changes

leoht reviewed May 6, 2022

View reviewed changes

Conversation

gawainhewitt commented May 3, 2022

User stories

README checklist

Uh oh!

archiemartini left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

leoht left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants