Open
Conversation
|
You've been honest that you based this work on a video walkthrough - and it seems to be a very nice and concise piece of work, particularly the way you managed other classes through dependency injection and the very concise code. In one place I would say that maybe the code was more concise than my current knowledge. Did you manage to work on the README at all? Perhaps something start thinking about. Nice work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archie Martin
This is a total rip off of the exemplar. I was so lost with the challenge I thought it might be a better exercise to go through bit by bit. Now I know some od these things being used, and where I should research..
https://www.youtube.com/watch?v=mgiJKdH9x8c&ab_channel=SamMorgan
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!