Farzan's TakeAway Challenge 3/4 user stories#2241
Open
Farzan-I wants to merge 2 commits intomakersacademy:mainfrom
Open
Farzan's TakeAway Challenge 3/4 user stories#2241Farzan-I wants to merge 2 commits intomakersacademy:mainfrom
Farzan-I wants to merge 2 commits intomakersacademy:mainfrom
Conversation
ErlantzR
reviewed
May 3, 2022
| @@ -0,0 +1,26 @@ | |||
| class Order | |||
There was a problem hiding this comment.
Name of variables are quite adequate and easy to understand what the code is trying to do
| @basket = [] | ||
| end | ||
|
|
||
| def choose_dish(dish) |
There was a problem hiding this comment.
It might need to include a way ask for more than one of each dish. A hash for @Basket could help on that
| @@ -0,0 +1,13 @@ | |||
| class ViewMenu | |||
There was a problem hiding this comment.
This might have been a method inside Menu class?
| @@ -0,0 +1,32 @@ | |||
| require 'order' | |||
There was a problem hiding this comment.
All features seem to be tested thoroughly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Farzan Imanzadeh
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!