fix: publish-pypi でルート Cargo.toml もバージョンパッチする#74
Merged
Conversation
packages/pypi は path = "../.." でルートクレートに依存しており、 clap の #[command(version)] がルートの CARGO_PKG_VERSION を コンパイル時に埋め込む。ルート Cargo.toml をパッチしないと `mille --version` が1つ前のバージョンを表示してしまう。 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv pip install mille後のmille --versionが1つ前のバージョンを表示する問題を修正publish-pypiジョブの version sync ステップにルートCargo.tomlの sed パッチを追加packages/pypiはpath = "../.."でルートクレートに依存しており、clap がCARGO_PKG_VERSION（ルート）をコンパイル時に埋め込むためTest plan
uv pip install mille && mille --versionでリリースタグと一致することを確認🤖 Generated with Claude Code