Skip to content

fix error in sklift.viz #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix error in sklift.viz #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sklift/viz/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import matplotlib.pyplot as plt
import numpy as np
from sklearn.utils.validation import check_consistent_length
from sklearn.utils import check_matplotlib_support
# from sklearn.utils import check_matplotlib_support

from ..utils import check_is_binary
from ..metrics import (
Expand Down Expand Up @@ -95,7 +95,7 @@ def plot(self, auc_score, ax=None, name=None, title=None, **kwargs):
Returns:
Object that stores computed values
"""
check_matplotlib_support('UpliftCurveDisplay.plot')
# check_matplotlib_support('UpliftCurveDisplay.plot')

name = self.estimator_name if name is None else name

Expand Down Expand Up @@ -174,7 +174,7 @@ def plot_qini_curve(y_true, uplift, treatment,

qini_disp.figure_.suptitle("Qini curve");
"""
check_matplotlib_support('plot_qini_curve')
# check_matplotlib_support('plot_qini_curve')
check_consistent_length(y_true, uplift, treatment)
check_is_binary(treatment)
check_is_binary(y_true)
Expand Down Expand Up @@ -238,7 +238,7 @@ def plot_uplift_curve(y_true, uplift, treatment,

uplift_disp.figure_.suptitle("Uplift curve");
"""
check_matplotlib_support('plot_uplift_curve')
# check_matplotlib_support('plot_uplift_curve')
check_consistent_length(y_true, uplift, treatment)
check_is_binary(treatment)
check_is_binary(y_true)
Expand Down
Loading