Skip to content

Identify webhook result http 2xx as OK #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maksim-paskal merged 1 commit into from
Dec 20, 2024
Merged

Identify webhook result http 2xx as OK #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/webhook/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ func SetHTTPClient(c *http.Client) {
client = c
}

func isResponseStatusOK(statusCode int) bool {
return statusCode >= 200 && statusCode < 300
}

func SendWebHook(ctx context.Context, obj *template.MessageType) error {
ctx, cancel := context.WithTimeout(ctx, *config.Get().WebHookTimeout)
defer cancel()
Expand Down Expand Up @@ -85,7 +89,7 @@ func SendWebHook(ctx context.Context, obj *template.MessageType) error {

log.Infof("response status: %s", resp.Status)

if resp.StatusCode != http.StatusOK {
if !isResponseStatusOK(resp.StatusCode) {
return errors.Wrap(errHTTPNotOK, fmt.Sprintf("StatusCode=%d", resp.StatusCode))
}

Expand Down
Loading