-
Notifications
You must be signed in to change notification settings - Fork 38
Enhanced dendrogram with heatmap feature #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you @rishabh240405. Would you be able to share a figure showing what this looks like with some of the malariaGEN data? |
Dear Sir, Thank you for reviewing my pull request, I have generated a figure showcasing how the heatmap looks with MalariaGEN data. Please find the attached image for reference. Also, I sincerely apologize for an oversight in the code I attached for the pull request. It includes both the dendrogram and volcano plot, which may not run together. The volcano plot function, however, runs completely fine on its own. I truly regret not paying closer attention to this and apologize again for any inconvenience caused. Looking forward to your feedback. Best regards, |
This is great @rishabh240405. Could you create a notebook (e.g., |
Thank you for your response, I have created a notebook (VolcanoPlotNotebook
.ipynb) demonstrating how to use the function which I have sent to you via mail.
Currently, I have used a sample dataset instead of the malaria data from
the API. If you prefer, I can update the notebook to use the real dataset.
Please let me know your preference, and I'll proceed accordingly. Also
please let me know if I can assist and contribute in any other way.
Best regards,
Rishabh
…On Wed, Apr 2, 2025 at 7:58 PM Jon Brenas ***@***.***> wrote:
This is great @rishabh240405 <https://github.com/rishabh240405>. Could
you create a notebook (e.g., notebooks/enhanced_dendrogram.ipynb) that
shows how to use the function?
—
Reply to this email directly, view it on GitHub
<#750 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BGZSPXZRJS3OIIIOAXXCZ5T2XPXYFAVCNFSM6AAAAAB2IX7FESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZSG42DKMJWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: jonbrenas]*jonbrenas* left a comment
(malariagen/malariagen-data-python#750)
<#750 (comment)>
This is great @rishabh240405 <https://github.com/rishabh240405>. Could
you create a notebook (e.g., notebooks/enhanced_dendrogram.ipynb) that
shows how to use the function?
—
Reply to this email directly, view it on GitHub
<#750 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BGZSPXZRJS3OIIIOAXXCZ5T2XPXYFAVCNFSM6AAAAAB2IX7FESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZSG42DKMJWGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thank you @rishabh240405. It would be great to use the data from the API and push the notebook to this repo. |
@jonbrenas can you please kindly look for the permission issue for the malariagen data? |
Access is updated twice a week. I will check with the person doing it if you have been added today. |
Dear Sir, @jonbrenas |
Could you contact [email protected]? They should be able to help you. |
Not sure what the status of this PR is. |
I think it is abandoned. |
Thanks @jonbrenas . If there's no response after a short time (say, September) then I guess we'll close this. This PR can always be resurrected, if needs be. |
No description provided.