Fix build, and fix xcodeproj missing files#813
Open
s2mr wants to merge 1 commit intomalcommac:masterfrom
Open
Conversation
s2mr
commented
May 9, 2023
| case Calendar.Identifier.persian.description: self = .persian | ||
| case Calendar.Identifier.republicOfChina.description: self = .republicOfChina | ||
| case Calendar.Identifier.islamicTabular.description: self = .islamicTabular | ||
| case Calendar.Identifier.islamicTabular.description: self = .islamicTabular |
lpbas
approved these changes
Sep 8, 2023
lpbas
left a comment
lpbas
left a comment
There was a problem hiding this comment.
The changes look good!
Any plans on merging this? SwiftDate 7.0.0 won't install when using tuist for our project due to the Project file's missing files, and this could be the solution.
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the latest swiftlint 0.51.0, xcodeproj's prebuild script occurs a fatal error.
So, the build failed for users who use carthage and install the latest swiftlint.
And, xcodeproj file contains missing reference files. So I deleted it.
This PR contains the following:
Environment: