Add localstack integration testing#1
Open
devinrsmith wants to merge 1 commit intomalhotrashivam:sm-s3-pqfrom
Open
Add localstack integration testing#1devinrsmith wants to merge 1 commit intomalhotrashivam:sm-s3-pqfrom
devinrsmith wants to merge 1 commit intomalhotrashivam:sm-s3-pqfrom
Conversation
malhotrashivam
pushed a commit
that referenced
this pull request
Jul 11, 2025
…archicalTableViewSubscription snapshots. (deephaven#6984) This consists of three actual changes: 1. The HierarchicalTableView subscriptions would call snapshot, etc. from their update propagation job. This resulted in sorts that had no context. In the Core+ case, this meant we could not correctly log performance in the face of sorted rollups. This is the root of this entire PR. 2. The FunctionGeneratedTableFactory had a similar problem when refreshing a table. 3. I added a flag to PerformanceEntry that will fail when the auth context is not set. It defaults to false, to avoid breaking Core users unnecessarily. In Enterprise, we are breaking already; so this is an appropriate setting. I also added it to the tests, to find other cases where we were broken (like the FunctionGeneratedTableFactory). The rest of this is just changing the tests to include a context. I think #1 and deephaven#2 are a point release candidate, but not the rest of the fixes/changes. --------- Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
malhotrashivam
pushed a commit
that referenced
this pull request
Aug 14, 2025
…archicalTableViewSubscription snapshots. (deephaven#6999) Cherry-pick of deephaven#6984 This consists of three actual changes: 1. The HierarchicalTableView subscriptions would call snapshot, etc. from their update propagation job. This resulted in sorts that had no context. In the Core+ case, this meant we could not correctly log performance in the face of sorted rollups. This is the root of this entire PR. 2. The FunctionGeneratedTableFactory had a similar problem when refreshing a table. 3. I added a flag to PerformanceEntry that will fail when the auth context is not set. It defaults to false, to avoid breaking Core users unnecessarily. In Enterprise, we are breaking already; so this is an appropriate setting. I also added it to the tests, to find other cases where we were broken (like the FunctionGeneratedTableFactory). The rest of this is just changing the tests to include a context. I think #1 and deephaven#2 are a point release candidate, but not the rest of the fixes/changes. --------- Co-authored-by: Ryan Caudy <rcaudy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.