Skip to content

[BUILD] Propagate INTERFACE_COMPILE_DEFINITIONS from API through comm… #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ Increment the:

## [Unreleased]

* [BUILD] Propagate INTERFACE_COMPILE_DEFINITIONS from API through common_foo_library
[#3440](https://github.com/open-telemetry/opentelemetry-cpp/pull/3440)

* [BUILD] Error out when building DLL without MSVC
[#3438](https://github.com/open-telemetry/opentelemetry-cpp/pull/3438)

Expand Down
2 changes: 1 addition & 1 deletion examples/common/foo_library/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ endif()

target_include_directories(common_foo_library
PUBLIC "$<BUILD_INTERFACE:${EXAMPLES_COMMON_DIR}>")
target_link_libraries(common_foo_library PRIVATE opentelemetry-cpp::api)
target_link_libraries(common_foo_library PUBLIC opentelemetry-cpp::api)
2 changes: 1 addition & 1 deletion examples/common/logs_foo_library/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ endif()
target_include_directories(common_logs_foo_library
PUBLIC $<BUILD_INTERFACE:${EXAMPLES_COMMON_DIR}>)

target_link_libraries(common_logs_foo_library PRIVATE opentelemetry-cpp::api)
target_link_libraries(common_logs_foo_library PUBLIC opentelemetry-cpp::api)
2 changes: 1 addition & 1 deletion examples/common/metrics_foo_library/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ endif()
target_include_directories(common_metrics_foo_library
PUBLIC $<BUILD_INTERFACE:${EXAMPLES_COMMON_DIR}>)

target_link_libraries(common_metrics_foo_library PRIVATE opentelemetry-cpp::api)
target_link_libraries(common_metrics_foo_library PUBLIC opentelemetry-cpp::api)