Skip to content

Make unary "-" work with @tf #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 12, 2018
Merged

Make unary "-" work with @tf #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a7680b0
Make unary "-" work with @tf
Nov 11, 2018
05922ad
To much syntactic sugar it seems.
Nov 11, 2018
e194348
add test for unary -
Nov 11, 2018
f1ec34f
prefix the function with @op
Nov 11, 2018
f044718
fix typo in test
Nov 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ops/math.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,9 @@ function Base.round(::Type{T}, value::AbstractTensor) where T
end


-(n::AbstractTensor) = negative(n)
@op function -(n::AbstractTensor; kwargs...)
negative(n; kwargs...)
end

@op function Base.complex(x_r::AbstractTensor, x_i::AbstractTensor; kwargs...)
Ops.complex(x_r, x_i; kwargs...)
Expand Down
6 changes: 5 additions & 1 deletion test/meta.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,11 @@ end
end
end


@testset "Negating and @tf" begin
a = constant(1)
@tf b = -a
@test true # Above line would have errored if unary - didn't work with @tf
end

@testset "Naming Big Demo" begin
let
Expand Down