Skip to content

Add BLE ad data generation method#113

Merged
malmeloo merged 3 commits intomalmeloo:mainfrom
shreyasminocha:pubkey-ble-conversion
Jul 18, 2025
Merged

Add BLE ad data generation method#113
malmeloo merged 3 commits intomalmeloo:mainfrom
shreyasminocha:pubkey-ble-conversion

Conversation

@shreyasminocha
Copy link
Contributor

@shreyasminocha shreyasminocha commented Feb 21, 2025

Resolves #100

Note

Please consider squashing and replacing the commit message.

@malmeloo
Copy link
Owner

I appreciate the effort, but I'm not sure if this is the right approach to implementing it. The library already contains code to extract the public key from broadcast data (see the scanner code), and it would probably make sense to implement the reverse operation in the library as well. A method in the HasPublicKey class would probably suffice.

@shreyasminocha shreyasminocha changed the title Add BLE data generation example Add BLE ad data generation method Feb 25, 2025
@malmeloo
Copy link
Owner

Looks good, but now the example is missing 😄. Do you want to add it or should I merge and add it myself?

@shreyasminocha
Copy link
Contributor Author

Ah, I misunderstood your last comment. I can add the example!

@malmeloo
Copy link
Owner

I've made some tiny changes for the sake of flexibility and method naming consistency. I think it should be trivial enough so an example might not be necessary, but we can always add one later. Thanks again!

@malmeloo malmeloo merged commit 5c117dd into malmeloo:main Jul 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add example to generate broadcast data

2 participants