Add BLE ad data generation method#113
Merged
malmeloo merged 3 commits intomalmeloo:mainfrom Jul 18, 2025
Merged
Conversation
91fda2c to
8f53b17
Compare
Owner
|
I appreciate the effort, but I'm not sure if this is the right approach to implementing it. The library already contains code to extract the public key from broadcast data (see the scanner code), and it would probably make sense to implement the reverse operation in the library as well. A method in the |
Owner
|
Looks good, but now the example is missing 😄. Do you want to add it or should I merge and add it myself? |
Contributor
Author
|
Ah, I misunderstood your last comment. I can add the example! |
Owner
|
I've made some tiny changes for the sake of flexibility and method naming consistency. I think it should be trivial enough so an example might not be necessary, but we can always add one later. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #100
Note
Please consider squashing and replacing the commit message.