Update version of ruff and fix lint errors#132
Merged
malmeloo merged 2 commits intomalmeloo:mainfrom May 27, 2025
Merged
Conversation
NickCrews
force-pushed
the
logger-not-logging
branch
3 times, most recently
from
c25f4a2 to
34c38a2
Compare
Contributor
Author
|
ah, I think it has to do with the ruff version in pre-commit-config being older than the one in uv.lock. I bumped the version in pre-commit. |
Aslo fix up a few other ruff lint errors.
NickCrews
force-pushed
the
logger-not-logging
branch
from
34c38a2 to
6de83e8
Compare
NickCrews
changed the title
Owner
|
Thanks for all the contributions recently! I indeed keep forgetting to bump ruff in the pre-commit config every time dependencies are updated :-). Maybe I should add a CI workflow just to assert that the versions are the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure why CI isn't getting these ruff errors, but my IDE is. Do you want me to investigate and make it so that CI will fail these in the future?