Merged
Conversation
Owner
|
Thanks! Setuptools was detecting other directories as packages before, and the error message said to include that. Guess I should've done a bit more research before including that line 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv buildwas producing an empty wheel when building from Git (only included the metadata and no code), meaning the package couldn't be used. Somehow, a regular pip install git+ worked...I've never seen
py-modulesused, but judging by the docs, it's not the completely correct solution here.packagesis the usual way of whitelisting what to include and it seems to fix the issue.Reproducible example:
After the fix:
*PS: Thanks for this amazing library! I'm working on a little