Fix decryption on Ventura 13.6 for bare-metal M1 instances #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey! Sorry for taking a while to respond. Your changes look good but I've left one suggestion to improve, if you can fix it I'll be happy to merge. Also tip: if you install pre-commit and the checks as detailed in the readme, you can check these rules locally 🙂 |
Author
|
Hi, I don't see any review comments? Could you point me in the right direction? Thanks |
malmeloo
requested changes
Dec 30, 2025
| "/usr/bin/security find-generic-password -l 'BeaconStore' -w" | ||
| ) | ||
| if not key_in_hex: | ||
| raise ValueError("Empty output from security -w") # noqa: EM101, TRY003, TRY301 |
Owner
There was a problem hiding this comment.
Please fix these linter errors instead of ignoring them
Owner
|
Sorry, forgot to publish them 😅 |
Author
|
I'll push changes this weekend, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running Find My decryption on a bare-metal M1 instance (Ventura 13.6) on Scaleway, I encountered an issue: the AES key resolved as empty (key_in_hex: ''), causing decryption to fail. Surprisingly, no password prompt appeared, even though I was connected via VNC (not SSH).
This patch adjusts the authentication/decryption flow, which resolved the issue in my environment. Decryption now completes successfully on Ventura 13.6 on bare-metal M1 instances.
It is only a fallback, so it shouldn't impact any other users.