Skip to content

fix: More robust retries on empty response #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malmeloo merged 2 commits into from
Jan 5, 2026
Merged

fix: More robust retries on empty response #215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4048438
fix: more robust retry mechanism on empty response
malmeloo Jan 5, 2026
66e790e
fix: remove weird spacing in logs
malmeloo Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions findmy/reports/account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,7 @@ async def _do_request() -> util.http.HttpResponse:
# Symptom: HTTP 200 but empty response
# Remove when real issue fixed
retry_counter = 1
_max_retries = 5
while True:
resp = await self._http.post(
self._ENDPOINT_REPORTS_FETCH,
Expand All @@ -663,23 +664,28 @@ async def _do_request() -> util.http.HttpResponse:
if resp.status_code != 200 or resp.text().strip():
return resp

logger.warning(
"Empty response received when fetching reports, retrying (%d/3)",
retry_counter,
)
retry_counter += 1

if retry_counter > 3:
if retry_counter > _max_retries:
logger.warning(
"Max retries reached, returning empty response. \
Location reports might be missing!"
"Max retries reached, returning empty response. "
"Location reports might be missing!"
)
msg = (
"Empty response received from Apple servers. "
"This is most likely a bug on Apple's side."
"More info: https://github.com/malmeloo/FindMy.py/issues/185"
)
msg = "Empty response received from Apple servers. \
This is most likely a bug on Apple's side. \
More info: https://github.com/malmeloo/FindMy.py/issues/185"
raise EmptyResponseError(msg)

await asyncio.sleep(2)
retry_time = 2 * retry_counter
logger.warning(
"Empty response received when fetching reports, retrying in %d seconds (%d/%d)",
retry_time,
retry_counter,
_max_retries,
)

await asyncio.sleep(retry_time)
retry_counter += 1

r = await _do_request()
if r.status_code == 401:
Expand Down