Skip to content

Commit c9c1f05

Browse files
committed
Demo + screenshots
1 parent 41ec942 commit c9c1f05

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ If you haven't migrated to AndroidX, use version 1.3.2. Versions 1.4.0 and up us
1616
- Learn how to [style the dialog](https://github.com/maltaisn/calcdialoglib/wiki/Styling-the-calculator) with the attributes
1717

1818
## Screenshots
19-
<img src="screenshots/demo.gif" alt="Demo" width="400px"/> <img src="screenshots/errors.gif" alt="Errors" width="400px"/>
19+
<img src="screenshots/demo.gif" alt="Demo" width="400px"/> <img src="screenshots/currency.gif" alt="Errors" width="400px"/>
2020
(Screenshots date back to version 1.0.0)
2121

2222
## Changelog

app/src/main/java/com/maltaisn/calcdialoglib/MainActivity.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import java.math.BigDecimal;
3232
import java.text.NumberFormat;
3333

34+
import androidx.annotation.NonNull;
3435
import androidx.annotation.Nullable;
3536
import androidx.appcompat.app.AppCompatActivity;
3637
import androidx.fragment.app.FragmentManager;
@@ -44,6 +45,9 @@ public class MainActivity extends AppCompatActivity implements CalcDialog.CalcDi
4445
@Nullable
4546
private BigDecimal value;
4647

48+
@NonNull
49+
private NumberFormat nbFmt = NumberFormat.getInstance();
50+
4751
@Override
4852
protected void onCreate(Bundle state) {
4953
super.onCreate(state);
@@ -125,20 +129,19 @@ public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
125129
@Override
126130
public void onClick(View v) {
127131
// Set dialog settings
128-
NumberFormat nbFmt;
129132
if (nbFmtTypeGroup.getCheckedRadioButtonId() == R.id.radio_nbfmt_default) {
130133
nbFmt = NumberFormat.getInstance();
131134
} else {
132135
nbFmt = NumberFormat.getCurrencyInstance();
133136
}
134137
nbFmt.setMaximumIntegerDigits(maxIntChk.isChecked() ?
135138
Integer.valueOf(maxIntEdt.getText().toString()) : Integer.MAX_VALUE);
136-
nbFmt.setMaximumFractionDigits(maxFracChk.isChecked() ?
139+
nbFmt.setMaximumFractionDigits(maxFracChk.isChecked() && minValEdt.length() > 0 ?
137140
Integer.valueOf(maxFracEdt.getText().toString()) : Integer.MAX_VALUE);
138141

139-
BigDecimal minValue = minValChk.isChecked() ?
142+
BigDecimal minValue = minValChk.isChecked() && minValEdt.length() > 0 ?
140143
new BigDecimal(minValEdt.getText().toString()) : null;
141-
BigDecimal maxValue = maxValChk.isChecked() ?
144+
BigDecimal maxValue = maxValChk.isChecked() && maxValEdt.length() > 0 ?
142145
new BigDecimal(maxValEdt.getText().toString()) : null;
143146
CalcNumpadLayout numpadLayout = numpadLayoutGroup.getCheckedRadioButtonId() == R.id.radio_numpad_calc ?
144147
CalcNumpadLayout.CALCULATOR : CalcNumpadLayout.PHONE;
@@ -192,7 +195,7 @@ private void updateValueText() {
192195
if (value == null) {
193196
valueTxv.setText(R.string.result_value_none);
194197
} else {
195-
valueTxv.setText(value.toPlainString());
198+
valueTxv.setText(nbFmt.format(value));
196199
}
197200
}
198201

screenshots/currency.gif

4.44 MB
Loading

screenshots/demo.gif

2.48 MB
Loading

screenshots/errors.gif

-1.19 MB
Binary file not shown.

0 commit comments

Comments
 (0)