Skip to content

GroupHorizontallyCenter#29

Open
MontakOleg wants to merge 3 commits intomamaral:masterfrom
MontakOleg:master
Open

GroupHorizontallyCenter#29
MontakOleg wants to merge 3 commits intomamaral:masterfrom
MontakOleg:master

Conversation

@MontakOleg
Copy link
Contributor

I use Facade in my current project and adds methods which missing for me..)

@mamaral
Copy link
Owner

mamaral commented Oct 18, 2015

Looks good - minor comment though, if the method signature said centered rather than center it would be a bit closer to the current naming conventions.

@MontakOleg
Copy link
Contributor Author

Ok, then should we also rename

  • (void)groupVertically:(NSArray *)subviews centerWithSpacing:(CGFloat)spacing width:(CGFloat)width height:(CGFloat)height;

?

@mamaral
Copy link
Owner

mamaral commented Oct 18, 2015

That was what I was referring to.

[edit] Oh right, I misread that. Yes I would.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants