Skip to content

fix: precedence for rc files, CONDARC/MAMBARC env vars#3894

Open
holzman wants to merge 1 commit intomamba-org:mainfrom
holzman:rcfile-precedence
Open

fix: precedence for rc files, CONDARC/MAMBARC env vars#3894
holzman wants to merge 1 commit intomamba-org:mainfrom
holzman:rcfile-precedence

Conversation

@holzman
Copy link
Contributor

@holzman holzman commented Apr 11, 2025

This code changes the rc file precedence to match the documentation and fixes a bug where if CONDARC or MAMBARC were set that it was ignoring all other configuration files.

This should solve #3126 (and maybe #2135 and possibly even #3841- I need to check).

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.31%. Comparing base (a25529e) to head (89d2d24).

Files with missing lines Patch % Lines
libmamba/src/api/configuration.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3894      +/-   ##
==========================================
- Coverage   63.31%   63.31%   -0.01%     
==========================================
  Files         315      315              
  Lines       38751    38748       -3     
  Branches     2980     2978       -2     
==========================================
- Hits        24535    24532       -3     
  Misses      14147    14147              
  Partials       69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@holzman holzman force-pushed the rcfile-precedence branch from cc0420f to 506b959 Compare May 14, 2025 18:38
@holzman holzman marked this pull request as ready for review May 14, 2025 18:38
@jjerphan jjerphan added the release::bug_fixes For PRs fixing bugs label Nov 28, 2025
This code changes the rc file precedence to match the documentation
and fixes a bug where if CONDARC or MAMBARC were set that it was
ignoring all other configuration files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::bug_fixes For PRs fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants