fix: Clone pip packages with environment#4153
Draft
jjerphan wants to merge 1 commit intomamba-org:mainfrom
Draft
fix: Clone pip packages with environment#4153jjerphan wants to merge 1 commit intomamba-org:mainfrom
jjerphan wants to merge 1 commit intomamba-org:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4153 +/- ##
==========================================
- Coverage 51.13% 51.10% -0.04%
==========================================
Files 236 236
Lines 27645 27664 +19
Branches 2832 2833 +1
==========================================
Hits 14137 14137
- Misses 13505 13524 +19
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JohanMabille
requested changes
Jan 27, 2026
jjerphan
force-pushed
the
fix/clone-pip-packages-with-environment
branch
6 times, most recently
from
712a0e9 to
fa5a935
Compare
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
force-pushed
the
fix/clone-pip-packages-with-environment
branch
3 times, most recently
from
5cae6b0 to
635aca1
Compare
Member
Author
|
Actually, it would be worth refactoring a few elements to reuse the code for exporting a YAML file specification from an environment and creating one from such a specification. |
jjerphan
commented
Jan 29, 2026
Comment on lines
+153
to
+154
| // Install packages from config | ||
| const auto& install_specs_vec = config.at("specs").value<std::vector<std::string>>(); |
Member
Author
There was a problem hiding this comment.
This is inspired from one of the install path, but we must not install those specifications modifying the configuration…
Member
Author
|
#4158 should come first. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up of #4102 (comment).
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.