Skip to content

Fix calculation of sha256 sum for archives (fixes #37) #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pberndt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix calculation of sha256 sum for archives (fixes #37) #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fetch_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def get_micromamba(version, use_default_version):

# compute the sha256
sha256 = hashlib.sha256()
with open(outdir / f"micromamba-{dplat}", "rb") as f:
with open(outdir / f"micromamba-{dplat}{ext}", "rb") as f:
Copy link
Copy Markdown
Member

@Hind-M Hind-M Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this.
There are actually 2 checksums to compute and write (one for the archive and another for the executable) and they need to be written in the corresponding .sha256 files.
So we would need to add another sha256 for either the executable (if you change this line) or leave this as is and add the one for the archive.

sha256.update(f.read())

with open(outdir / f"micromamba-{dplat}{ext}.sha256", "w") as f:
Expand Down