Skip to content

Include bin hash in cache key #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelzw merged 5 commits into from
Oct 2, 2024
Merged

Include bin hash in cache key #228

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a3facb
Include bin hash in cache key
bhperry Sep 30, 2024
7e8b873
Update src/cache.ts
bhperry Oct 1, 2024
cc64441
Compile dist and bump version
bhperry Oct 1, 2024
1e5044a
use readFile
bhperry Oct 1, 2024
0e536a4
fix tests
pavelzw Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ const generateEnvironmentKey = (options: Options, prefix: string) => {
const envName = options.environmentName ? `-${options.environmentName}` : ''
const createArgs = options.createArgs ? `-args-${sha256Short(JSON.stringify(options.createArgs))}` : ''
const rootPrefix = `-root-${sha256Short(options.micromambaRootPath)}`
const key = `${prefix}${arch}${envName}${createArgs}${rootPrefix}`
const binHash = fs.readBinaryFile(options.micromambaBinPath).then((content) => {
return sha256(content)
})

const key = `${prefix}${arch}${envName}${createArgs}${rootPrefix}-bin-${binHash}`

if (options.environmentFile) {
return fs.readFile(options.environmentFile, 'utf-8').then((content) => {
Expand Down