Adding St Helens as Source #5446
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbr111
requested changes
Feb 10, 2026
| def __init__(self, postcode: str, uprn: str): | ||
| self._postcode = postcode.upper() | ||
| self._uprn = str(uprn).zfill(12) | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| if not self._postcode: | |
| raise SourceArgumentException(postcode, "Postcode is required") | |
| if not self._uprn.isdigit(): | |
| raise SourceArgumentException(uprn, "UPRN must be numeric") |
|
|
||
| class Source: | ||
| def __init__(self, postcode: str, uprn: str): | ||
| self._postcode = postcode.upper() |
Collaborator
There was a problem hiding this comment.
Suggested change
| self._postcode = postcode.upper() | |
| self._postcode = postcode.strip().upper() |
| class Source: | ||
| def __init__(self, postcode: str, uprn: str): | ||
| self._postcode = postcode.upper() | ||
| self._uprn = str(uprn).zfill(12) |
Comment on lines
+47
to
+48
| except Exception as err: | ||
| _LOGGER.error("Failed to get initial form and variables: %s", err) |
Collaborator
There was a problem hiding this comment.
Exception is logged but code will continue
consider to raise RuntimeError("Failed to get initial form") from err
Comment on lines
+44
to
+46
| response = session.get( | ||
| "https://www.sthelens.gov.uk/article/3473/Check-your-collection-dates" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| response = session.get( | |
| "https://www.sthelens.gov.uk/article/3473/Check-your-collection-dates" | |
| ) | |
| response = session.get( | |
| "https://www.sthelens.gov.uk/article/3473/Check-your-collection-dates", | |
| timeout=30 | |
| ) |
use timeout
| ) | ||
|
|
||
| try: | ||
| response = session.post(api_url, data=payload) |
Collaborator
There was a problem hiding this comment.
Suggested change
| response = session.post(api_url, data=payload) | |
| response = session.post(api_url, data=payload, timeout=30) |
same here
bbr111
reviewed
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding source for St Helens town. Ive checked and the authority does not expose any apis 😞, so falling back to dedicated source 😄 .
✅ Documentation updated
✅ Unit tests Passed
✅ Local Testing of Integration Passed