-
Notifications
You must be signed in to change notification settings - Fork 148
test_library_get_key_path check #2648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-D-Petrov
approved these changes
Sep 17, 2025
IvoDD
approved these changes
Sep 18, 2025
IvoDD
reviewed
Sep 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However it looks like it still fails for conda on the CI?
…ons.ClientError) as e:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
Start running test with conda once again: 50 runs: https://github.com/man-group/ArcticDB/actions/runs/17730467752
Creating bucket now retries on ClientError 400 also and not only to EndpointConnectionError
This should fix also: https://github.com/man-group/ArcticDB/actions/runs/17843532292/job/50738667004
Validation link for Build and Test: https://github.com/man-group/ArcticDB/actions/runs/17849282592
The fix does not seems to work ... We continue to to get ClientError: https://github.com/man-group/ArcticDB/actions/runs/17856250740/job/50775866306?pr=2648.
The code is trying to run Moto (seen from 'OSError(98, 'Address already in use')'). It manages to do that at port 20579. Then we try to create the bucket 15 times ... But for some reason we always get
Ok. Trying to make bucket name use - instead of _ ... This seems to be one important recommendation that is not true with our code
Coverage after the change:
https://github.com/man-group/ArcticDB/actions/runs/17937971277
https://github.com/man-group/ArcticDB/actions/runs/17937631291/job/51006702552?pr=2648
The error still exist. Made new modifications to print out the actual error message. It seems like we are trying to comnect to Azurite that is running on the same port - that means that a Moto S3 gets free port but in mean time Azurite is spawned there. Solution - introduce get_buckets_check operation that will be always executed upon start of Moto S3. If that operation is not successfull a new attempt will be triggered to obtain another free port with different seed this time.
Additional validation avail here: https://github.com/man-group/ArcticDB/actions/runs/17978603290
A new version where server identifies itself as Moto AWS S3 or Moto GCP is created.
Additional validation run: https://github.com/man-group/ArcticDB/actions/runs/18095773997
Real Storage Test: https://github.com/man-group/ArcticDB/actions/runs/18095823526
Any other comments?
Checklist
Checklist for code changes...