Fix batch_append and batch_update bust version chain if upsert #2661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoebusm
requested review from
alexowens90,
IvoDD and
poodlewars
as code owners
phoebusm
force-pushed
the
fix/batch_append_update_bust_version_chain
branch
2 times, most recently
from
7799f08 to
9b6a9f8
Compare
alexowens90
approved these changes
Sep 22, 2025
IvoDD
approved these changes
Sep 26, 2025
phoebusm
force-pushed
the
fix/batch_append_update_bust_version_chain
branch
from
9b6a9f8 to
47b3f2e
Compare
phoebusm
force-pushed
the
fix/batch_append_update_bust_version_chain
branch
from
33e3908 to
f5a1f20
Compare
|
|
phoebusm
force-pushed
the
fix/batch_append_update_bust_version_chain
branch
from
f7b8dcb to
f5a1f20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
https://man312219.monday.com/boards/7852509418/pulses/9903341116
What does this implement or fix?
Existing code incorrectly assumes when the symbol being upsert is not live, it has never existed. So the version being upserted has always been set to 0.
But the symbol could exist but deleted at that moment. So the version being upserted has always been set to 0. If so, this will bust the version chain.
This PR also fixes exception thrown in writing version keys being swallowed
Any other comments?
Checklist
Checklist for code changes...