Skip to content

base: allow symlinks outside of the archive#101

Merged
avdgrinten merged 2 commits intomanagarm:masterfrom
no92:tar-unpack
Feb 22, 2026
Merged

base: allow symlinks outside of the archive#101
avdgrinten merged 2 commits intomanagarm:masterfrom
no92:tar-unpack

Conversation

@no92
Copy link
Copy Markdown
Member

@no92 no92 commented Feb 17, 2026

The default behavior was changed by python 3.14, so we pass the argument to revert to the previous one.

Copy link
Copy Markdown
Member

@ArsenArsen ArsenArsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i didn't realize this fix also needs to be in xbstrap

https://github.com/managarm/xbbs/blob/78403ecd907611ec001365349d045555e9062e16/xbbs/buildsystem/xbstrap/worker.py#L173-L180

this will break on earlier versions though I think? I had some reason for checking for 3.12 specifically, best replicate that probably (or at least test it on py3.11, 3.12, 3.13 and 3.14)

The default behavior was changed by python 3.14, so we pass the argument
to revert to the previous one.
@no92
Copy link
Copy Markdown
Member Author

no92 commented Feb 18, 2026

Replicated the xbbs code here.

@avdgrinten avdgrinten merged commit 11737b2 into managarm:master Feb 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants