base: allow symlinks outside of the archive#101
Merged
avdgrinten merged 2 commits intomanagarm:masterfrom Feb 22, 2026
Merged
Conversation
ArsenArsen
reviewed
Feb 18, 2026
Member
ArsenArsen
left a comment
There was a problem hiding this comment.
oh i didn't realize this fix also needs to be in xbstrap
this will break on earlier versions though I think? I had some reason for checking for 3.12 specifically, best replicate that probably (or at least test it on py3.11, 3.12, 3.13 and 3.14)
The default behavior was changed by python 3.14, so we pass the argument to revert to the previous one.
Member
Author
|
Replicated the xbbs code here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default behavior was changed by python 3.14, so we pass the argument to revert to the previous one.