Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the workspace to support multiple contracts by moving the converter contract to a contracts directory, centralizes dependency management through workspace configuration, and optimizes WASM build processes with artifact compression and CI enhancements.
- Migrated converter contract from root to contracts/converter directory structure
- Implemented workspace-level dependency management for consistent versioning
- Added WASM optimization tools and build configurations for smaller artifacts
Reviewed Changes
Copilot reviewed 5 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| converter/Cargo.toml | Removed old converter manifest from root directory |
| contracts/converter/Cargo.toml | New converter manifest using workspace dependencies |
| Cargo.toml | Added workspace dependencies and release optimizations |
| .github/workflows/ci.yml | Enhanced CI with WASM optimization and artifact handling |
| .cargo/config.toml | Added rustflags for WASM size optimization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request restructures the workspace to support multiple contracts, centralizes dependency management, and enhances the build and CI processes for WASM artifacts. The main changes include moving the
convertercontract into a newcontractsdirectory, consolidating dependencies in the workspace, optimizing WASM builds, and updating CI workflows for improved artifact handling and optimization.Workspace and Dependency Management:
convertercontract from the root tocontracts/converter, and removed the oldconverter/Cargo.tomlin favor of a new one in the contracts directory. Dependencies are now managed centrally in the workspace for easier maintenance and consistency. [1] [2] [3][workspace.dependencies]section toCargo.tomlto unify dependency versions and features across all contracts.Build and Release Optimization:
.cargo/config.tomlto strip symbols from WASM builds usingrustflags, reducing artifact size.Cargo.tomlfor smaller, faster builds (lto,opt-level, etc.).Continuous Integration and Artifact Handling:
.github/workflows/ci.ymlto build and optimize all WASM targets, install necessary tools (protoc,wasm-opt), and upload optimized artifacts for all contracts, not justconverter.These changes make the repository more scalable for multiple contracts, ensure consistent dependency management, and produce smaller, optimized WASM artifacts for deployment.