Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades IBC module imports and related keeper and middleware initializations from v8 to v10 to support IBCv2 functionality. The key changes include:
- Updating import paths for IBC modules from v8 to v10 across several files.
- Removing the legacy capability keeper, associated scope variables, and memory store mounting.
- Refactoring keeper initializations (e.g., switching to runtime.NewKVStoreService) and introducing new IBC router and middleware for IBCv2.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/test_helpers.go | Upgraded IBC module import paths to v10. |
| app/decorators/msg_filter_test.go | Updated IBC import paths for transfer and client types in tests. |
| app/app.go | Major refactor of IBC keeper initialization, removal of legacy capability keeper and memory stores, and addition of new IBCv2 routing. |
| app/ante.go | Upgraded IBC module import paths to v10. |
Files not reviewed (1)
- go.mod: Language not supported
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
- Coverage 75.98% 75.51% -0.47%
==========================================
Files 36 36
Lines 2344 2308 -36
==========================================
- Hits 1781 1743 -38
- Misses 470 473 +3
+ Partials 93 92 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to update dependencies and refactor the codebase. The most important changes involve upgrading the IBC-Go module from version 8 to version 10, removing the capability module, and updating various dependencies in the
go.modfile.Dependency Updates:
v8tov10in multiple files, includingapp/ante.go,app/app.go,app/decorators/msg_filter_test.go, andapp/test_helpers.go[1] [2] [3] [4].github.com/CosmWasm/wasmdfromv0.54.0tov0.55.0.google.golang.org/protobuffromv1.36.4tov1.36.5.github.com/bgentry/speakeasyandgithub.com/bits-and-blooms/bitset.Codebase Refactoring:
app/app.go, includingCapabilityKeeper, scoped keepers, and memory store keys [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16].These updates and refactoring efforts are aimed at improving the codebase by leveraging the latest features and improvements in the upgraded dependencies while removing obsolete or unnecessary components.