Skip to content

test: chain upgrade#136

Draft
fmorency wants to merge 2 commits intomanifest-network:mainfrom
fmorency:tha-upgrader
Draft

test: chain upgrade#136
fmorency wants to merge 2 commits intomanifest-network:mainfrom
fmorency:tha-upgrader

Conversation

@fmorency
Copy link
Collaborator

Relates #strangelove-ventures/poa#245

This pull request updates the chain upgrade test for the Manifest Ledger to support the new POA validator induction flow and improves test reliability and coverage. The main changes include updating the chain versions, introducing a new validator induction test after upgrade, and refactoring helper functions for validator management.

Chain upgrade and validator induction improvements:

  • Updated upgrade test to use newer chain and upgrade versions (v1.0.5v1.0.9) and changed repository to ghcr.io/liftedinit/manifest-ledger for more accurate upgrade scenarios.
  • Added a test flow for inducting a new validator after upgrade, including creating a validator, submitting a POA create-validator transaction, and verifying induction using the POA module. [1] [2]
  • Added helper functions for creating POA validator management messages: createValidator, createSetPowerProposal, createRemoveValidatorProposal, and createSetStakingParamsProposal for improved test readability and reuse.
  • Introduced POACreateValidator helper to submit POA validator creation transactions, aligning with the new induction flow.

Test configuration and reliability improvements:

  • Increased default genesis amount and transaction gas prices for test accounts to improve reliability and reduce test flakiness.
  • Added test constants for a new validator (val1Mnemonic, val1Addr, val1Pubkey) to support induction scenarios.
  • Reduced the number of validators used in upgrade tests for faster execution and easier validator management.
  • Added logic to update staking parameters (unbonding time) in tests for more flexible validator management and to highlight a known POA issue with validator unbonding during upgrades.

These changes ensure the upgrade test accurately reflects real-world validator induction scenarios and improve the maintainability and reliability of the test suite.

@fmorency fmorency requested a review from Copilot September 10, 2025 15:01
@fmorency fmorency self-assigned this Sep 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the chain upgrade test for the Manifest Ledger to support the new POA validator induction flow and improves test reliability and coverage. The changes upgrade the chain versions from v1.0.5 to v1.0.9 and switch to the ghcr.io/liftedinit/manifest-ledger repository for more accurate upgrade scenarios.

Key changes include:

  • Updating chain versions and repository for the upgrade test
  • Adding a new validator induction test flow after upgrade with POA module integration
  • Improving test configuration with higher gas prices and genesis amounts for better reliability

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
interchaintest/setup.go Adds validator test constants, increases gas prices and genesis amounts for test reliability
interchaintest/poa_group_test.go Introduces POA validator management helper functions for creating validators and staking parameter proposals
interchaintest/helpers/poa.go Adds POACreateValidator helper function for submitting POA validator creation transactions
interchaintest/chain_upgrade_test.go Updates upgrade versions, adds comprehensive validator induction test after upgrade with staking parameter management

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants