Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the chain upgrade test for the Manifest Ledger to support the new POA validator induction flow and improves test reliability and coverage. The changes upgrade the chain versions from v1.0.5 to v1.0.9 and switch to the ghcr.io/liftedinit/manifest-ledger repository for more accurate upgrade scenarios.
Key changes include:
- Updating chain versions and repository for the upgrade test
- Adding a new validator induction test flow after upgrade with POA module integration
- Improving test configuration with higher gas prices and genesis amounts for better reliability
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| interchaintest/setup.go | Adds validator test constants, increases gas prices and genesis amounts for test reliability |
| interchaintest/poa_group_test.go | Introduces POA validator management helper functions for creating validators and staking parameter proposals |
| interchaintest/helpers/poa.go | Adds POACreateValidator helper function for submitting POA validator creation transactions |
| interchaintest/chain_upgrade_test.go | Updates upgrade versions, adds comprehensive validator induction test after upgrade with staking parameter management |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #strangelove-ventures/poa#245
This pull request updates the chain upgrade test for the Manifest Ledger to support the new POA validator induction flow and improves test reliability and coverage. The main changes include updating the chain versions, introducing a new validator induction test after upgrade, and refactoring helper functions for validator management.
Chain upgrade and validator induction improvements:
v1.0.5→v1.0.9) and changed repository toghcr.io/liftedinit/manifest-ledgerfor more accurate upgrade scenarios.createValidator,createSetPowerProposal,createRemoveValidatorProposal, andcreateSetStakingParamsProposalfor improved test readability and reuse.POACreateValidatorhelper to submit POA validator creation transactions, aligning with the new induction flow.Test configuration and reliability improvements:
val1Mnemonic,val1Addr,val1Pubkey) to support induction scenarios.These changes ensure the upgrade test accurately reflects real-world validator induction scenarios and improve the maintainability and reliability of the test suite.