Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Extracts a reusable type alias for the registry option expected by SigningStargateClient.connectWithSigner, improving readability and keeping the cast aligned with the upstream function signature.
Changes:
- Added a
SigningClientRegistrytype alias derived fromSigningStargateClient.connectWithSigner’s options parameter. - Replaced the inline conditional type cast with the new alias in
CosmosClientManager.getSigningClient().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a type alias to clarify and improve type safety when casting the
registryparameter forSigningStargateClient.connectWithSigner. The main change is the extraction of the expectedregistrytype into a reusable alias, which is then used in theCosmosClientManagerclass for better readability and maintainability.Type safety and code clarity improvements:
SigningClientRegistrytype alias to extract the expectedregistrytype from theSigningStargateClient.connectWithSignerfunction signature, ensuring type-safe casting and improving code clarity insrc/client.ts.registryin theCosmosClientManagerclass to use the newSigningClientRegistryalias instead of an inline conditional type.