Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies the DecCoin type definition by making it a direct alias of the existing Coin type, and updates the documentation to clarify DecCoin’s intended semantic usage (decimal amounts in distribution contexts).
Changes:
- Replaced the standalone
DecCoininterface withexport type DecCoin = Coin - Expanded the
DecCoinJSDoc to explain decimal-amount semantics and common usage contexts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
DecCointype definition to simplify and clarify its relationship with the existingCointype. The most important change is thatDecCoinis now defined as an alias ofCoin, reflecting that they share the same structure.Type definition simplification:
DecCointype from a separate interface to a type alias ofCoininsrc/types.ts, and improved the documentation to clarify its usage and structure.