fix code cov 2 #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=========================================
Coverage ? 54.62%
=========================================
Files ? 65
Lines ? 12272
Branches ? 0
=========================================
Hits ? 6703
Misses ? 5102
Partials ? 467 |
manitgupta
pushed a commit
that referenced
this pull request
Jan 7, 2025
…latform#945) * Check constraint backend (#9) Backend Support for Check Constraint * update api * fix PR comment * remove api call to while validating constraints * Fixed db collation regex to remove collation name from the results * renamed function name to formatCheckConstraints and added check if constraint name is empty * fixed PR comments * added test case for the empty check constraint name * fix: added regular exprression to match the exact column * fix: added regular expression to replace table name * Added test case for the column rename for check constraint * 1. Refactored GetConstraint function 2. Fixed inforschema unit tests * added comment at handling case for check constraints * reverted white spaces * reverted white spaces * nit: doesCheckConstraintNameExist * added comments for doesCheckConstraintNameExist * PR and UT fixes * fix UT * UT fix * Removed isCheckConstraintsTablePresent function * moved regex globally * Fix UT * fixed UT * fixed handling of the constraints * removed unused function * added unit tests for incompatable name * Combined unit tests * added test case for the renaming column having substring of other column * added the query changes which return distinct value * Updating version of msprod (GoogleCloudPlatform#969) * fix(deps): update module golang.org/x/net to v0.33.0 [security] (GoogleCloudPlatform#967) Co-authored-by: Vardhan Vinay Thigle <[email protected]> * feat: APIs for Backend Changes for Default Values (GoogleCloudPlatform#965) * backend apis * linting * comment changes * comment changes * feat: default value for mysql source (GoogleCloudPlatform#963) * source dv * test fix * change * comment changes * test fix * change * fix github v * change * Check constraint backend (#9) Backend Support for Check Constraint * 1. Refactored GetConstraint function 2. Fixed inforschema unit tests * removed duplicate function * Fixed UT --------- Co-authored-by: taherkl <[email protected]> Co-authored-by: Akash Thawait <[email protected]> Co-authored-by: Vivek Yadav <[email protected]> Co-authored-by: Vardhan Vinay Thigle <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Astha Mohta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>