Skip to content

Conversation

@PavelShilin89
Copy link
Contributor

@PavelShilin89 PavelShilin89 commented Nov 9, 2025

Summary

Add comprehensive test coverage for force_bigrams parameter in all three contexts from issue #3853.

Changes

This PR adds a new test file call-autocomplete-force-bigrams-vertical.rec with 19 tests covering:

1. CALL AUTOCOMPLETE with force_bigrams (9 tests)

  • Verifies force_bigrams=1 finds transposition errors in long words
  • Verifies force_bigrams=0 does NOT find transpositions in long words
  • Tests combinations with append, prepend, and fuzziness options

2. CALL SUGGEST with force_bigrams (5 tests)

  • Tests fuzzy suggestions with bigram matching
  • CALL SUGGEST is fuzzy by default, so tests verify force_bigrams behavior

3. SELECT with OPTION fuzzy=1 and force_bigrams (5 tests)

  • Tests regular search queries with fuzzy option and force_bigrams
  • Verifies the combination works correctly

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

Windows test results

    3 files      3 suites   25m 58s ⏱️
1 114 tests 1 060 ✅ 54 💤 0 ❌
1 116 runs  1 062 ✅ 54 💤 0 ❌

Results for commit 14fa292.

♻️ This comment has been updated with latest results.

… Clarify comments for automatic bigram selection tests
…bigrams, but because fuzzy matching works despite different n-grams (bigrams vs trigrams) due to small edit distance.
@PavelShilin89 PavelShilin89 merged commit 1080322 into master Nov 26, 2025
115 checks passed
@PavelShilin89 PavelShilin89 deleted the test/issue-3853-auto-force-bigrams branch November 26, 2025 07:26
@PavelShilin89 PavelShilin89 changed the title Add comprehensive tests for force_bigrams option (issue #3853) Add comprehensive tests for force_bigrams option Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants