Remove ipykernel pin to fix qtconsole #35618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Purpose of work
The mslice
qtconsoleis currently broken. mantidproject/mslice#910This is fixed by upgrading
ipykernelto the latest version. In order to to this the pin must be removed from workbench.ipykernelwas pinned "to deal with an issue with ipykernel v6 and incompatibility with qtconsole/workbench, at present it stops workbench from loading." This is no longer the case with the latest verison ofipykernel,Summary of work
Remove
ipykernelpin.To test:
Packages here: https://builds.mantidproject.org/job/build_packages_from_branch/
Check all tests pass
Ensure workbench loads and appears to operate correctly.
Check function of
qtconsolein bothworkbenchand inmsliceinterface by running some existing scripts.Fixes mantidproject/mslice#910
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.