Skip to content

Conversation

@MialLewis
Copy link
Contributor

@MialLewis MialLewis commented May 26, 2023

Description of work

Purpose of work
The mslice qtconsole is currently broken. mantidproject/mslice#910

This is fixed by upgrading ipykernel to the latest version. In order to to this the pin must be removed from workbench.

ipykernel was pinned "to deal with an issue with ipykernel v6 and incompatibility with qtconsole/workbench, at present it stops workbench from loading." This is no longer the case with the latest verison of ipykernel,

Summary of work

Remove ipykernel pin.

To test:
Packages here: https://builds.mantidproject.org/job/build_packages_from_branch/
Check all tests pass
Ensure workbench loads and appears to operate correctly.
Check function of qtconsole in both workbench and in mslice interface by running some existing scripts.

Fixes mantidproject/mslice#910

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Are the release notes saved in a separate file, using Issue or PR number for file name and in the correct location?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@MialLewis MialLewis requested a review from thomashampson May 26, 2023 10:40
@MialLewis MialLewis marked this pull request as ready for review May 26, 2023 10:41
@MialLewis MialLewis changed the base branch from main to release-next May 26, 2023 10:44
@MialLewis MialLewis force-pushed the 0_remove_ipykernel_pin branch from 22e9985 to fb957c1 Compare May 26, 2023 12:22
@MialLewis MialLewis force-pushed the 0_remove_ipykernel_pin branch from fb957c1 to 36f0d9c Compare May 26, 2023 12:26
@sf1919 sf1919 added this to the Release 6.7 milestone May 26, 2023
@sf1919 sf1919 added the High Priority An issue or pull request that if not addressed is severe enough to postponse a release. label May 30, 2023
Copy link
Contributor

@SilkeSchomann SilkeSchomann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked all items in the test section. In addition, I have installed the package both as a conda package and as a windows exe. In both cases it was possible to start workbench without error messages. I could not carry out the notebook validation from the manual test instructions for core though as notebook is not available in this package.

@MialLewis
Copy link
Contributor Author

MialLewis commented May 30, 2023

This PR brings back the first issue mentioned here: #34134

This is because ipykernel have introduced debugpy as a dependency which conflicts with pydevd used by pycharm.

In ipykernel 6.4.0 debugpy was made an optional dependency ipython/ipykernel#767

You can therefore remove debugpy from a developer environment using conda remove --force debugpy. This removes the warning and leaves the console functional.

I imagine this is not best practice as it leaves the environment in an unresolved state, but ipykernel is currently the only dependant package on debugpy so it should be ok.

@sf1919
Copy link
Contributor

sf1919 commented May 30, 2023

@MialLewis can you raise an issue to update the Pycharm dev docs as part of maintenance? Add it to the maintenance board please

@thomashampson can you take a look at this?

@sf1919 sf1919 removed the request for review from thomashampson May 31, 2023 07:29
@gemmaguest gemmaguest merged commit 4a7c11b into release-next May 31, 2023
@gemmaguest gemmaguest deleted the 0_remove_ipykernel_pin branch May 31, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority An issue or pull request that if not addressed is severe enough to postponse a release.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

MSlice hangs or crashes when using the jupyter console

5 participants